[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
02/02: gnu: Go 1.9: Fix test failure with binutils >= 2.31.
From: |
Leo Famulari |
Subject: |
02/02: gnu: Go 1.9: Fix test failure with binutils >= 2.31. |
Date: |
Sun, 7 Oct 2018 21:19:52 -0400 (EDT) |
lfam pushed a commit to branch core-updates
in repository guix.
commit 0a3e9bf62171b051656f24b81094064b479ebf2e
Author: Leo Famulari <address@hidden>
Date: Sun Oct 7 21:08:38 2018 -0400
gnu: Go 1.9: Fix test failure with binutils >= 2.31.
* gnu/packages/golang.scm (go-1.9)[arguments]: Add a substitution to the
prebuild phase.
---
gnu/packages/golang.scm | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 7f26fbd..1ce06a4 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -273,6 +273,15 @@ in the style of communicating sequential processes
(@dfn{CSP}).")
(string-append
"\"-Wl,-rpath=" gcclib "\", \"-lgcc_s\", ")))
+ ;; XXX Commit 65fa2b615b72c1fa61a7 in the Go repo. We do this
+ ;; without a patch because ((guix packages) patch-and-repack)
+ ;; resets file mtimes, and parts of Go's test suite rely on
+ ;; those timestamps.
+ ;; <https://github.com/golang/go/issues/26369>
+ (substitute* "cmd/internal/objfile/elf.go"
+ (("PT_LOAD")
+ "PT_LOAD && p.Flags&elf.PF_X != 0"))
+
;; Disable failing tests: these tests attempt to access
;; commands or network resources which are neither available
;; nor necessary for the build to succeed.