guix-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

10/16: guix build: '--keep-failed' implies '--no-offload'.


From: guix-commits
Subject: 10/16: guix build: '--keep-failed' implies '--no-offload'.
Date: Mon, 25 Nov 2019 18:17:08 -0500 (EST)

civodul pushed a commit to branch master
in repository guix.

commit 2ce08a5d79f6eb1d2d3839aca859559b9829ae36
Author: Ludovic Courtès <address@hidden>
Date:   Thu Nov 21 15:41:11 2019 +0100

    guix build: '--keep-failed' implies '--no-offload'.
    
    * guix/scripts/build.scm (set-build-options-from-command-line): Pass
     #:offload? #f when 'keep-failed? is true.
    * doc/guix.texi (Common Build Options): Document it.
---
 doc/guix.texi          | 6 +++---
 guix/scripts/build.scm | 3 ++-
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index 5756b6a..a64b0fb 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -8051,9 +8051,9 @@ the end of the build log.  This is useful when debugging 
build issues.
 @xref{Debugging Build Failures}, for tips and tricks on how to debug
 build issues.
 
-This option has no effect when connecting to a remote daemon with a
-@code{guix://} URI (@pxref{The Store, the @code{GUIX_DAEMON_SOCKET}
-variable}).
+This option implies @option{--no-offload}, and it has no effect when
+connecting to a remote daemon with a @code{guix://} URI (@pxref{The
+Store, the @code{GUIX_DAEMON_SOCKET} variable}).
 
 @item --keep-going
 @itemx -k
diff --git a/guix/scripts/build.scm b/guix/scripts/build.scm
index acb495a..a853ac6 100644
--- a/guix/scripts/build.scm
+++ b/guix/scripts/build.scm
@@ -545,7 +545,8 @@ talking to a remote daemon\n")))
                      #:fallback? (assoc-ref opts 'fallback?)
                      #:use-substitutes? (assoc-ref opts 'substitutes?)
                      #:substitute-urls (assoc-ref opts 'substitute-urls)
-                     #:offload? (assoc-ref opts 'offload?)
+                     #:offload? (and (assoc-ref opts 'offload?)
+                                     (not (assoc-ref opts 'keep-failed?)))
                      #:max-silent-time (assoc-ref opts 'max-silent-time)
                      #:timeout (assoc-ref opts 'timeout)
                      #:print-build-trace (assoc-ref opts 'print-build-trace?)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]