06/16: gnu: MariaDB: Remove workaround package.

[guix-commits]

mbakke pushed a commit to branch staging
in repository guix.

commit ca69163cc5aac9ff15a358449ed229631434a4fa
Author: Marius Bakke <address@hidden>
AuthorDate: Sun Jan 19 10:36:55 2020 +0100

    gnu: MariaDB: Remove workaround package.
    
    * gnu/packages/databases.scm (mariadb)[arguments]: Add substitution for the
    'mysql_install_db' script.
    (mariadb/fixed-install-db): Remove variable.
    (libdbi-drivers)[native-inputs]: Change from MARIADB/FIXED-INSTALL-DB to 
MARIADB.
---
 gnu/packages/databases.scm | 34 ++++++----------------------------
 1 file changed, 6 insertions(+), 28 deletions(-)

diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
index ca15c77..283c892 100644
--- a/gnu/packages/databases.scm
+++ b/gnu/packages/databases.scm
@@ -879,6 +879,11 @@ Language.")
               (rename-file (string-append out "/bin/mysql_config")
                            (string-append dev "/bin/mysql_config"))
 
+
+              (substitute*  (string-append out "/bin/mysql_install_db")
+                (("\\$basedir/share/mysql")
+                 (string-append lib "/share/mysql")))
+
               ;; Embed an absolute reference to OpenSSL in mysql_config
               ;; and the pkg-config file to avoid propagation.
               (substitute* (list (string-append dev "/bin/mysql_config")
@@ -914,33 +919,6 @@ Language.")
 as a drop-in replacement of MySQL.")
     (license license:gpl2)))
 
-;; TODO: mysql_install_db is broken in MariaDB.  This package is here as
-;; a workaround for packages that need it.  Merge with 'mariadb' in the next
-;; rebuild cycle.
-(define-public mariadb/fixed-install-db
-  (hidden-package
-   (package/inherit
-    mariadb
-    (name "mariadb-fixed")
-    (native-inputs '())
-    (inputs
-     `(("mariadb" ,mariadb)
-       ("mariadb:lib" ,mariadb "lib")))
-    (outputs '("out"))
-    (build-system trivial-build-system)
-    (arguments
-     `(#:modules ((guix build utils))
-       #:builder
-       (begin
-         (use-modules ((guix build utils)))
-         (let ((out (assoc-ref %outputs "out")))
-           (copy-recursively (assoc-ref %build-inputs "mariadb") out)
-           (substitute*  (string-append out "/bin/mysql_install_db")
-             (("\\$basedir/share/mysql")
-              (string-append (assoc-ref %build-inputs "mariadb:lib")
-                             "/share/mysql")))
-           #t)))))))
-
 ;; Don't forget to update the other postgresql packages when upgrading this 
one.
 (define-public postgresql
   (package
@@ -3278,7 +3256,7 @@ simultaneous database connections by using this 
framework.")
      `(;; For tests.
        ("inetutils" ,inetutils)
        ("glibc-locales" ,glibc-locales)
-       ("mariadb" ,mariadb/fixed-install-db)))
+       ("mariadb" ,mariadb)))
     (inputs
      `(("libdbi" ,libdbi)
        ("mariadb:dev" ,mariadb "dev")