01/06: ui: Do not display error messages with bare format strings.

[guix-commits]

civodul pushed a commit to branch master
in repository guix.

commit a07d5e558b5403dad0a59776b950b6b02169c249
Author: Ludovic Courtès <address@hidden>
AuthorDate: Fri Jan 24 10:13:10 2020 +0100

    ui: Do not display error messages with bare format strings.
    
    On Guile 3, with, say, an error in ~/.guile, we'd get:
    
      $ guix repl
      guix repl: error: Unbound variable: ~S
    
    * guix/ui.scm (call-with-error-handling): Add
    '&exception-with-kind-and-args' case.
---
 guix/ui.scm | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/guix/ui.scm b/guix/ui.scm
index 4857a88..a47dafe 100644
--- a/guix/ui.scm
+++ b/guix/ui.scm
@@ -770,6 +770,17 @@ directories:~{ ~a~}~%")
                            (gettext (condition-message c) %gettext-domain))
              (display-hint (condition-fix-hint c))
              (exit 1))
+
+            ;; On Guile 3.0.0, exceptions such as 'unbound-variable' come are
+            ;; compound and include a '&message'.  However, that message only
+            ;; contains the format string.  Thus, special-case it here to
+            ;; avoid displaying a bare format string.
+            ((cond-expand
+               (guile-3
+                ((exception-predicate &exception-with-kind-and-args) c))
+               (else #f))
+             (raise c))
+
             ((message-condition? c)
              ;; Normally '&message' error conditions have an i18n'd message.
              (leave (G_ "~a~%")