04/09: tests: "make check-system" no longer interns source upfront.

[guix-commits]

civodul pushed a commit to branch master
in repository guix.

commit dd1ee160be8ba4e211432c08e161c24901cd670e
Author: Ludovic Courtès <address@hidden>
AuthorDate: Tue Mar 3 12:35:46 2020 +0100

    tests: "make check-system" no longer interns source upfront.
    
    * gnu/ci.scm (channel-build-system)[build, lower]: Honor #:source.
    (channel-source->package): New procedure.
    (system-test-jobs): Remove 'instance' and call to
    'checkout->channel-instance'.  Use 'channel-source->package'.
    * build-aux/run-system-tests.scm (tests-for-channel-instance): Rename to...
    (tests-for-current-guix): ... this.  Change 'instance' to 'source'.
    (run-system-tests): Use 'local-file' instead of 'interned-file' for
    SOURCE.
---
 build-aux/run-system-tests.scm | 17 ++++++++---------
 gnu/ci.scm                     | 32 ++++++++++++++++++--------------
 2 files changed, 26 insertions(+), 23 deletions(-)

diff --git a/build-aux/run-system-tests.scm b/build-aux/run-system-tests.scm
index b0cb3bd..a4c019a 100644
--- a/build-aux/run-system-tests.scm
+++ b/build-aux/run-system-tests.scm
@@ -1,5 +1,5 @@
 ;;; GNU Guix --- Functional package management for GNU
-;;; Copyright © 2016, 2018, 2019 Ludovic Courtès <address@hidden>
+;;; Copyright © 2016, 2018, 2019, 2020 Ludovic Courtès <address@hidden>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -19,7 +19,8 @@
 (define-module (run-system-tests)
   #:use-module (gnu tests)
   #:use-module (gnu packages package-management)
-  #:use-module ((gnu ci) #:select (channel-instance->package))
+  #:use-module ((gnu ci) #:select (channel-source->package))
+  #:use-module (guix gexp)
   #:use-module (guix store)
   #:use-module ((guix status) #:select (with-status-verbosity))
   #:use-module (guix monads)
@@ -51,15 +52,15 @@
                 lst)
          (lift1 reverse %store-monad))))
 
-(define (tests-for-channel-instance instance)
-  "Return a list of tests for perform, using Guix from INSTANCE, a channel
+(define (tests-for-current-guix source)
+  "Return a list of tests for perform, using Guix built from SOURCE, a channel
 instance."
   ;; Honor the 'TESTS' environment variable so that one can select a subset
   ;; of tests to run in the usual way:
   ;;
   ;;   make check-system TESTS=installed-os
   (parameterize ((current-guix-package
-                  (channel-instance->package instance)))
+                  (channel-source->package source)))
     (match (getenv "TESTS")
       (#f
        (all-system-tests))
@@ -80,14 +81,12 @@ instance."
         ;; Intern SOURCE so that 'build-from-source' in (guix channels) sees
         ;; "fresh" file names and thus doesn't find itself loading .go files
         ;; from ~/.cache/guile when it loads 'build-aux/build-self.scm'.
-        ;; XXX: It would be best to not do it upfront because we may need it.
-        (mlet* %store-monad ((source (interned-file source "guix-source"
+        (mlet* %store-monad ((source -> (local-file source "guix-source"
                                                     #:recursive? #t
                                                     #:select?
                                                     (or (git-predicate source)
                                                         (const #t))))
-                             (instance -> (checkout->channel-instance source))
-                             (tests -> (tests-for-channel-instance instance))
+                             (tests ->  (tests-for-current-guix source))
                              (drv (mapm %store-monad system-test-value tests))
                              (out -> (map derivation->output-path drv)))
           (format (current-error-port) "Running ~a system tests...~%"
diff --git a/gnu/ci.scm b/gnu/ci.scm
index 9094cc0..9dc530b 100644
--- a/gnu/ci.scm
+++ b/gnu/ci.scm
@@ -28,6 +28,7 @@
   #:use-module (guix derivations)
   #:use-module (guix build-system)
   #:use-module (guix monads)
+  #:use-module (guix gexp)
   #:use-module (guix ui)
   #:use-module ((guix licenses)
                 #:select (gpl3+ license? license-name))
@@ -54,7 +55,7 @@
   #:use-module (srfi srfi-1)
   #:use-module (srfi srfi-26)
   #:use-module (ice-9 match)
-  #:export (channel-instance->package
+  #:export (channel-source->package
             hydra-jobs))
 
 ;;; Commentary:
@@ -239,29 +240,35 @@ system.")
 (define channel-build-system
   ;; Build system used to "convert" a channel instance to a package.
   (let* ((build (lambda* (store name inputs
-                                #:key instance system
+                                #:key source commit system
                                 #:allow-other-keys)
                   (run-with-store store
-                    (channel-instances->derivation (list instance))
+                    (mlet* %store-monad ((source (lower-object source))
+                                         (instance
+                                          -> (checkout->channel-instance
+                                              source #:commit commit)))
+                      (channel-instances->derivation (list instance)))
                     #:system system)))
-         (lower (lambda* (name #:key system instance #:allow-other-keys)
+         (lower (lambda* (name #:key system source commit
+                               #:allow-other-keys)
                   (bag
                     (name name)
                     (system system)
                     (build build)
-                    (arguments `(#:instance ,instance))))))
+                    (arguments `(#:source ,source
+                                 #:commit ,commit))))))
     (build-system (name 'channel)
                   (description "Turn a channel instance into a package.")
                   (lower lower))))
 
-(define (channel-instance->package instance)
-  "Return a package for the given channel INSTANCE."
+(define* (channel-source->package source #:key commit)
+  "Return a package for the given channel SOURCE, a lowerable object."
   (package
     (inherit guix)
-    (version (or (string-take (channel-instance-commit instance) 7)
-                 (string-append (package-version guix) "+")))
+    (version (string-append (package-version guix) "+"))
     (build-system channel-build-system)
-    (arguments `(#:instance ,instance))
+    (arguments `(#:source ,source
+                 #:commit ,commit))
     (inputs '())
     (native-inputs '())
     (propagated-inputs '())))
@@ -269,9 +276,6 @@ system.")
 (define* (system-test-jobs store system
                            #:key source commit)
   "Return a list of jobs for the system tests."
-  (define instance
-    (checkout->channel-instance source #:commit commit))
-
   (define (test->thunk test)
     (lambda ()
       (define drv
@@ -308,7 +312,7 @@ system.")
       ;; expensive.  It also makes sure we get a valid Guix package when this
       ;; code is not running from a checkout.
       (parameterize ((current-guix-package
-                      (channel-instance->package instance)))
+                      (channel-source->package source #:commit commit)))
         (map ->job (all-system-tests)))
       '()))