05/09: ui: Factorize '&message' handling.

[guix-commits]

civodul pushed a commit to branch master
in repository guix.

commit efe037fc5cc3134bbc3ef4e36b49a3f788921b68
Author: Ludovic Courtès <ludo@gnu.org>
AuthorDate: Sat Jul 25 15:50:36 2020 +0200

    ui: Factorize '&message' handling.
    
    * guix/ui.scm (call-with-error-handling): Factorize the three
    'message-condition?' clauses into one.
---
 guix/ui.scm | 18 +++++-------------
 1 file changed, 5 insertions(+), 13 deletions(-)

diff --git a/guix/ui.scm b/guix/ui.scm
index 27bcade..588eb84 100644
--- a/guix/ui.scm
+++ b/guix/ui.scm
@@ -782,17 +782,14 @@ directories:~{ ~a~}~%")
                      (invoke-error-stop-signal c)
                      (cons (invoke-error-program c)
                            (invoke-error-arguments c))))
-             ((and (error-location? c) (message-condition? c))
-              (report-error (error-location c) (G_ "~a~%")
+             ((message-condition? c)
+              ;; Normally '&message' error conditions have an i18n'd message.
+              (report-error (and (error-location? c) (error-location c))
+                            (G_ "~a~%")
                             (gettext (condition-message c) %gettext-domain))
               (when (fix-hint? c)
                 (display-hint (condition-fix-hint c)))
               (exit 1))
-             ((and (message-condition? c) (fix-hint? c))
-              (report-error (G_ "~a~%")
-                            (gettext (condition-message c) %gettext-domain))
-              (display-hint (condition-fix-hint c))
-              (exit 1))
 
              ;; On Guile 3.0.0, exceptions such as 'unbound-variable' are
              ;; compound and include a '&message'.  However, that message only
@@ -806,12 +803,7 @@ directories:~{ ~a~}~%")
                 (guile-3
                  ((exception-predicate &exception-with-kind-and-args) c))
                 (else #f))
-              (raise c))
-
-             ((message-condition? c)
-              ;; Normally '&message' error conditions have an i18n'd message.
-              (leave (G_ "~a~%")
-                     (gettext (condition-message c) %gettext-domain))))
+              (raise c)))
       ;; Catch EPIPE and the likes.
       (catch 'system-error
         thunk