Re: branch master updated: Add (guix android-repo-download).

[Danny Milosavljevic]

Hi Mathieu,

> It seems that the comments I did here were not addressed:
> https://issues.guix.gnu.org/42800#5. Nothing big, but if you can have a
> small look :).

Ohhhh!  I'm sorry, I overlooked it.

I've pushed follow-up commit eb924a97bd04e8e1d09664fbb08cd6712025376d to fix
some of the things you pointed out.

Thanks for your review and thanks for pointing it out!

>> +  #:use-module (git) ; FIXME Remove
>Why should it be removed?

Because (git) is a Scheme git client implementation, and android-repo uses the
usual executable instead (that's done inside the "repo" tool--which is also an
executable).

>Spaces in env variable names are quite unusual.

It's modeled after the git-download module, which does the same.

It's basically to make it stand out so it cannot be confused with an
environment variable that has actually been set by some build (i.e. by
the actual package upstream).

>It could also be useful to be able to select the manifest name, using the "-m" 
>switch.

How would that look?  I wrote the entire thing basically to be able to fetch
Replicant--and I don't know what "-m" does.

Are some of those options mutually exclusive?  Should the "manifest name" be
able to be set in the android-repo-reference by a package ?  Is it instead
of something else or in addition ?

>Any specific reason to default to 3 threads?

No--it's a leftover.

I changed it to use (parallel-job-count) in guix master commit
4ff0fed778172f80d938dfe42716cc9fefeb4fdc.

>> +  ;; TODO: Remove.
>> +  (define inputs
>> +    (standard-packages))

>Why should it be removed?

I don't like unused inputs.  I'm not sure which of those inputs are unused,
though.  A list of these inputs is in (gnu packages commencement)
%final-inputs, so it's: tar gzip bzip2 xz file diffutils patch findutils
gawk sed grep coreutils make bash ld-wrapper binutils gcc libc libc:static
locales.

pgpwOhhNGHb8v.pgp
Description: OpenPGP digital signature