guix-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

branch master updated: services: base: Improve container related comment


From: guix-commits
Subject: branch master updated: services: base: Improve container related comments.
Date: Mon, 21 Sep 2020 04:59:16 -0400

This is an automated email from the git hooks/post-receive script.

mothacehe pushed a commit to branch master
in repository guix.

The following commit(s) were added to refs/heads/master by this push:
     new 1a0da8b  services: base: Improve container related comments.
1a0da8b is described below

commit 1a0da8b4f38c11b70acbc641068d8e01144b8180
Author: Mathieu Othacehe <othacehe@gnu.org>
AuthorDate: Mon Sep 21 10:48:16 2020 +0200

    services: base: Improve container related comments.
    
    * gnu/services/base.scm (guix-shepherd-service): Clarify the usage of a
    container for guix-daemon.
---
 gnu/services/base.scm | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/gnu/services/base.scm b/gnu/services/base.scm
index d560ad5..bef4eef 100644
--- a/gnu/services/base.scm
+++ b/gnu/services/base.scm
@@ -1570,6 +1570,9 @@ proxy of 'guix-daemon'...~%")
                     ;; the 'set-http-proxy' action.
                     (or (getenv "http_proxy") #$http-proxy))
 
+                  ;; Start the guix-daemon from a container, when supported,
+                  ;; to solve an installation issue. See the comment below for
+                  ;; more details.
                   (fork+exec-command/container
                    (cons* #$(file-append guix "/bin/guix-daemon")
                           "--build-users-group" #$build-group
@@ -1600,6 +1603,8 @@ proxy of 'guix-daemon'...~%")
                    ;; operate from within the same MNT namespace as the
                    ;; installation container. In that case only, enter the
                    ;; namespace of the process PID passed as start argument.
+                   ;; Otherwise, for symmetry purposes enter the caller
+                   ;; namespaces which is a no-op.
                    #:pid (match args
                            ((pid) (string->number pid))
                            (else (getpid)))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]