[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
09/13: secret-service: Fix file port leak in 'secret-service-send-secret
|
From: |
guix-commits |
|
Subject: |
09/13: secret-service: Fix file port leak in 'secret-service-send-secrets'. |
|
Date: |
Tue, 29 Sep 2020 16:06:13 -0400 (EDT) |
civodul pushed a commit to branch master
in repository guix.
commit f9090015c58e6f47be74fe6116ef10a90378a899
Author: Ludovic Courtès <ludo@gnu.org>
AuthorDate: Tue Sep 29 09:35:35 2020 +0200
secret-service: Fix file port leak in 'secret-service-send-secrets'.
* gnu/build/secret-service.scm (secret-service-send-secrets): Use
'call-with-input-file' instead of 'open-input-file'.
---
gnu/build/secret-service.scm | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/gnu/build/secret-service.scm b/gnu/build/secret-service.scm
index 40c24ab..6697e6e 100644
--- a/gnu/build/secret-service.scm
+++ b/gnu/build/secret-service.scm
@@ -69,8 +69,10 @@ local PORT. If connect fails, sleep 1s and retry RETRY
times."
(version 0)
(files ,files-sizes-modes))))
(write secrets sock)
- (for-each (compose (cute dump-port <> sock)
- (cute open-input-file <>))
+ (for-each (lambda (file)
+ (call-with-input-file file
+ (lambda (input)
+ (dump-port input sock))))
files))))
(define (secret-service-receive-secrets port)
- 02/13: services: childhurd: Tweak description., (continued)
- 02/13: services: childhurd: Tweak description., guix-commits, 2020/09/29
- 03/13: secret-service: Clarify the origin of messages., guix-commits, 2020/09/29
- 07/13: services: hurd-vm: Pass "-no-reboot" when spawning the Hurd VM., guix-commits, 2020/09/29
- 04/13: services: hurd-vm: Check whether /dev/kvm exists at run time., guix-commits, 2020/09/29
- 05/13: services: guix: Generate key pair if needed during activation., guix-commits, 2020/09/29
- 06/13: services: hurd-vm: Initialize the guest's SSH/Guix keys at activation time., guix-commits, 2020/09/29
- 08/13: secret-service: Add a timeout when waiting for a client., guix-commits, 2020/09/29
- 10/13: services: secret-service: Move instance last in the list of services., guix-commits, 2020/09/29
- 13/13: services: hurd-vm: Add system test., guix-commits, 2020/09/29
- 11/13: services: secret-service: Add initial client/server handshake., guix-commits, 2020/09/29
- 09/13: secret-service: Fix file port leak in 'secret-service-send-secrets'.,
guix-commits <=
- 12/13: secret-service: Add proper logging procedure and log to syslog., guix-commits, 2020/09/29