[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
13/20: store: Micro-optimize object cache lookup.
From: |
guix-commits |
Subject: |
13/20: store: Micro-optimize object cache lookup. |
Date: |
Mon, 1 Mar 2021 09:32:11 -0500 (EST) |
civodul pushed a commit to branch wip-build-systems-gexp
in repository guix.
commit af3cb5caa12e2521c21747bedc4777c69e09d0d2
Author: Ludovic Courtès <ludo@gnu.org>
AuthorDate: Fri Feb 19 22:30:30 2021 +0100
store: Micro-optimize object cache lookup.
This avoids a closure allocation when 'lookup-cached-object' is called.
* guix/store.scm (lookup-cached-object): Avoid optional/keyword
arguments and inline.
(%mcached): Adjust accordingly.
---
guix/store.scm | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/guix/store.scm b/guix/store.scm
index dccf8ba..37ae6cf 100644
--- a/guix/store.scm
+++ b/guix/store.scm
@@ -1863,8 +1863,7 @@ and RESULT is typically its derivation."
(lambda (x y)
#t)))
-(define* (lookup-cached-object object #:optional (keys '())
- #:key (vhash-fold* vhash-foldq*))
+(define-inlinable (lookup-cached-object object keys vhash-fold*)
"Return the cached object in the store connection corresponding to OBJECT
and KEYS; use VHASH-FOLD* to look for OBJECT in the cache. KEYS is a list of
additional keys to match against, and which are compared with 'equal?'.
@@ -1895,7 +1894,7 @@ Return #f on failure and the cached result otherwise."
OBJECT/KEYS, or return its cached value. Use VHASH-CONS to insert OBJECT into
the cache, and VHASH-FOLD* to look it up."
(mlet %store-monad ((cached (lookup-cached-object object keys
- #:vhash-fold*
vhash-fold*)))
+ vhash-fold*)))
(if cached
(return cached)
(>>= (mthunk)
- 09/20: gexp: Micro-optimize 'gexp->sexp' and 'lower-inputs'., (continued)
- 09/20: gexp: Micro-optimize 'gexp->sexp' and 'lower-inputs'., guix-commits, 2021/03/01
- 12/20: grafts: Inline 'grafting?' and 'set-grafting'., guix-commits, 2021/03/01
- 15/20: serialization: Micro-optimize string literal output in 'write-file-tree'., guix-commits, 2021/03/01
- 16/20: gexp: Optimize 'with-build-variables'., guix-commits, 2021/03/01
- 17/20: packages: Default origin 'patch-flags' is a gexp., guix-commits, 2021/03/01
- 18/20: gexp: Add 'sexp->gexp'., guix-commits, 2021/03/01
- 08/20: gexp: Keep 'lower-inputs' private., guix-commits, 2021/03/01
- 10/20: store: Object cache profiling shows the number of entries., guix-commits, 2021/03/01
- 11/20: gexp: Reduce allocations while traversing lists., guix-commits, 2021/03/01
- 06/20: gexp: 'gexp-inputs' returns a list of <gexp-input> records., guix-commits, 2021/03/01
- 13/20: store: Micro-optimize object cache lookup.,
guix-commits <=
- 14/20: gexp: Reduce allocations in 'gexp-attribute'., guix-commits, 2021/03/01
- 20/20: build-system: Use 'input-tuples->gexp' and 'outputs->gexp'., guix-commits, 2021/03/01
- 19/20: build-system: Use 'sexp->gexp' for plain sexps., guix-commits, 2021/03/01