branch master updated: utils: Do not request block buffering in pretty-print-table.

[guix-commits]

This is an automated email from the git hooks/post-receive script.

apteryx pushed a commit to branch master
in repository guix.

The following commit(s) were added to refs/heads/master by this push:
     new 4f51a4a  utils: Do not request block buffering in pretty-print-table.
4f51a4a is described below

commit 4f51a4ac278d5001e0afdba3c5425e0bd6673505
Author: Maxim Cournoyer <maxim.cournoyer@gmail.com>
AuthorDate: Wed Jul 21 17:30:20 2021 -0400

    utils: Do not request block buffering in pretty-print-table.
    
    Re-testing 'guix package -A' using the default line buffering set in (guix
    ui), there doesn't seem to be a performance gain to use block buffering, so
    remove this extraneous side effect.
    
    * guix/utils.scm (pretty-print-table): Do not set buffering mode to block.
    
    Reported-by: Ludovic Courtès <ludo@gnu.org>
---
 guix/utils.scm | 1 -
 1 file changed, 1 deletion(-)

diff --git a/guix/utils.scm b/guix/utils.scm
index 2c56c8b..2920fa7 100644
--- a/guix/utils.scm
+++ b/guix/utils.scm
@@ -963,7 +963,6 @@ bound by MAX-COLUMN-WIDTH."
                               (map (cut min <> max-column-width)
                                    column-widths)))
          (fmt (string-append (string-join column-formats "\t") "\t~a")))
-    (setvbuf (current-output-port) 'block) ;for better performance
     (for-each (cut format #t "~?~%" fmt <>) rows)))
 
 ;;; Local Variables: