guix-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

02/07: build-system: linux-module: Don't explicitly return #t from phase


From: guix-commits
Subject: 02/07: build-system: linux-module: Don't explicitly return #t from phases.
Date: Fri, 1 Oct 2021 15:33:28 -0400 (EDT)

nckx pushed a commit to branch master
in repository guix.

commit bdd190e3aafa9b54ed93fefbe7c0307a9103d3ad
Author: Tobias Geerinckx-Rice <me@tobias.gr>
AuthorDate: Fri Oct 1 15:02:43 2021 +0200

    build-system: linux-module: Don't explicitly return #t from phases.
    
    * guix/build-system/linux-module.scm (configure): Remove explicit #t return 
value.
---
 guix/build/linux-module-build-system.scm | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/guix/build/linux-module-build-system.scm 
b/guix/build/linux-module-build-system.scm
index 7c0dba8..18ccf7c 100644
--- a/guix/build/linux-module-build-system.scm
+++ b/guix/build/linux-module-build-system.scm
@@ -34,7 +34,7 @@
 ;;
 ;; Code:
 
-;; Copied from make-linux-libre's "configure" phase.
+;; Similar to make-linux-libre's "configure" phase.
 (define* (configure #:key inputs target arch #:allow-other-keys)
   (setenv "KCONFIG_NOTIMESTAMP" "1")
   (setenv "KBUILD_BUILD_TIMESTAMP" (getenv "SOURCE_DATE_EPOCH"))
@@ -43,12 +43,11 @@
   (format #t "`ARCH' set to `~a'~%" (getenv "ARCH"))
 
   (when target
+    ;; TODO? (setenv "EXTRA_VERSION" ,extra-version)
+    ;; TODO? kernel ".config".
     (setenv "CROSS_COMPILE" (string-append target "-"))
     (format #t "`CROSS_COMPILE' set to `~a'~%"
-               (getenv "CROSS_COMPILE")))
-  ; TODO: (setenv "EXTRA_VERSION" ,extra-version)
-  ; TODO: kernel ".config".
-  #t)
+            (getenv "CROSS_COMPILE"))))
 
 (define* (build #:key (make-flags '()) (parallel-build? #t)
                 (source-directory ".")



reply via email to

[Prev in Thread] Current Thread [Next in Thread]