01/05: installer: Reorder file system type listbox.

[guix-commits]

nckx pushed a commit to branch master
in repository guix.

commit 3a7504cbc490f74d9b9d0a3a461058c1d6cafbe6
Author: Tobias Geerinckx-Rice <me@tobias.gr>
AuthorDate: Thu Sep 23 14:40:52 2021 +0200

    installer: Reorder file system type listbox.
    
    Recommending ext4 over btrfs is probably ill-advised nowadays.  See the
    regular bug reports about running out of /gnu/store directory entries,
    for which the documented fix then breaks booting with GRUB.
    
    Instead, just list regular file systems alphabetically.  We can bikeshed
    bcachefs later ;-)
    
    Move second-class file systems like NTFS to their own section at the end
    of the list.
    
    * gnu/packages/package-management.scm (run-fs-type-page): Reorder the
    LISTBOX-ITEMS.
---
 gnu/installer/newt/partition.scm | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/gnu/installer/newt/partition.scm b/gnu/installer/newt/partition.scm
index ea524eb..70c11ed 100644
--- a/gnu/installer/newt/partition.scm
+++ b/gnu/installer/newt/partition.scm
@@ -131,7 +131,11 @@ Be careful, all data on the disk will be lost.")
   (run-listbox-selection-page
    #:info-text (G_ "Please select the file-system type for this partition.")
    #:title (G_ "File-system type")
-   #:listbox-items '(ext4 btrfs fat16 fat32 jfs ntfs xfs swap)
+   #:listbox-items '(btrfs ext4 jfs xfs
+                           swap
+                           ;; These lack basic Unix features.  Their only use
+                           ;; on GNU is for interoperation, e.g., with UEFI.
+                           fat32 fat16 ntfs)
    #:listbox-item->text user-fs-type-name
    #:sort-listbox-items? #f
    #:button-text (G_ "Exit")