[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
79/180: gnu: diffutils: Fix signal processing.
From: |
guix-commits |
Subject: |
79/180: gnu: diffutils: Fix signal processing. |
Date: |
Fri, 29 Oct 2021 15:56:47 -0400 (EDT) |
apteryx pushed a commit to branch core-updates-frozen-batched-changes
in repository guix.
commit d93310760fc5347685292b440acac8969bb936fd
Author: Thiago Jung Bauermann <bauermann@kolabnow.com>
AuthorDate: Thu Sep 9 11:41:14 2021 -0300
gnu: diffutils: Fix signal processing.
diffutils has a race condition in its signal processing code which is easy
to
trigger on powerpc64le-linux. More often than not, it causes the ‘colors’
test to fail and therefore the build of the package fails as well.
Add the patch proposed in Debian bug 922552 which fixes the problem.
* gnu/packages/patches/diffutils-fix-signal-processing.patch: New file.
* gnu/local.mk (dist_patch_DATA): Add it.
* gnu/packages/base.scm (diffutils)[source]: Use it.
Signed-off-by: Maxim Cournoyer <maxim.cournoyer@gmail.com>
---
gnu/local.mk | 1 +
gnu/packages/base.scm | 3 +-
.../patches/diffutils-fix-signal-processing.patch | 58 ++++++++++++++++++++++
3 files changed, 61 insertions(+), 1 deletion(-)
diff --git a/gnu/local.mk b/gnu/local.mk
index c895307..1b31cf1 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -1000,6 +1000,7 @@ dist_patch_DATA =
\
%D%/packages/patches/desmume-gcc7-fixes.patch \
%D%/packages/patches/dfu-programmer-fix-libusb.patch \
%D%/packages/patches/diffoscope-fix-test_item3_deflate_llvm_bitcode.patch
\
+ %D%/packages/patches/diffutils-fix-signal-processing.patch \
%D%/packages/patches/diffutils-gets-undeclared.patch \
%D%/packages/patches/disarchive-cross-compilation.patch \
%D%/packages/patches/dkimproxy-add-ipv6-support.patch \
diff --git a/gnu/packages/base.scm b/gnu/packages/base.scm
index ebbb093..9395c7e 100644
--- a/gnu/packages/base.scm
+++ b/gnu/packages/base.scm
@@ -274,7 +274,8 @@ differences.")
(sha256
(base32
"09isrg0isjinv8c535nxsi1s86wfdfzml80dbw41dj9x3hiad9xk"))
- (patches (search-patches "coreutils-gnulib-tests.patch"))))
+ (patches (search-patches "coreutils-gnulib-tests.patch"
+
"diffutils-fix-signal-processing.patch"))))
(build-system gnu-build-system)
(native-inputs (list perl))
(synopsis "Comparing and merging files")
diff --git a/gnu/packages/patches/diffutils-fix-signal-processing.patch
b/gnu/packages/patches/diffutils-fix-signal-processing.patch
new file mode 100644
index 0000000..134dd3f
--- /dev/null
+++ b/gnu/packages/patches/diffutils-fix-signal-processing.patch
@@ -0,0 +1,58 @@
+Author: Frédéric Bonnard <frediz@debian.org>
+
+Obtained from:
+
+https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=922552#19
+
+Fixes bug reported upstream at:
+
+https://debbugs.gnu.org/cgi/bugreport.cgi?bug=34519
+
+diff --git a/src/diff.c b/src/diff.c
+index e2eb32437353..b574e8282dc9 100644
+--- a/src/diff.c
++++ b/src/diff.c
+@@ -1451,6 +1451,8 @@ compare_files (struct comparison const *parent,
+ }
+ }
+
++ final_process_signals ();
++
+ /* Now the comparison has been done, if no error prevented it,
+ and STATUS is the value this function will return. */
+
+diff --git a/src/diff.h b/src/diff.h
+index 03daaa4a0530..e177fe600a25 100644
+--- a/src/diff.h
++++ b/src/diff.h
+@@ -390,6 +390,7 @@ extern enum changes analyze_hunk (struct change *, lin *,
lin *, lin *, lin *);
+ extern void begin_output (void);
+ extern void debug_script (struct change *);
+ extern void fatal (char const *) __attribute__((noreturn));
++extern void final_process_signals (void);
+ extern void finish_output (void);
+ extern void message (char const *, char const *, char const *);
+ extern void message5 (char const *, char const *, char const *,
+diff --git a/src/util.c b/src/util.c
+index 4f4d9bb285eb..56d292de2927 100644
+--- a/src/util.c
++++ b/src/util.c
+@@ -237,6 +237,18 @@ process_signals (void)
+ }
+ }
+
++/* Process remaining signals once before exit */
++void
++final_process_signals (void)
++{
++ static int last = 1;
++
++ if (last) {
++ process_signals ();
++ last = 0;
++ }
++}
++
+ static void
+ install_signal_handlers (void)
+ {
- 83/180: gnu: gcc-5: Fix powerpc64le-linux build, (continued)
- 83/180: gnu: gcc-5: Fix powerpc64le-linux build, guix-commits, 2021/10/29
- 84/180: gnu: make-ld-wrapper: Add a LINKER argument., guix-commits, 2021/10/29
- 86/180: gnu: gdb: Patch references to /bin/sh and add debug output., guix-commits, 2021/10/29
- 89/180: aux-files: sitecustomize: Cleanup and add explanatory comments., guix-commits, 2021/10/29
- 90/180: gnu: glade3: Remove sitecustomize.py workaround., guix-commits, 2021/10/29
- 49/180: gnu: e2fsprogs: Update to 1.46.4., guix-commits, 2021/10/29
- 58/180: gnu: polkit: Update to 0.120 and ungraft., guix-commits, 2021/10/29
- 63/180: gnu: gst-plugins-bad: Update to 1.18.5., guix-commits, 2021/10/29
- 80/180: gnu: diffutils: Update to 3.8., guix-commits, 2021/10/29
- 85/180: gnu: Add ld-gold-wrapper., guix-commits, 2021/10/29
- 79/180: gnu: diffutils: Fix signal processing.,
guix-commits <=
- 93/180: gnu: Build all Rust packages using the latest rustc., guix-commits, 2021/10/29
- 94/180: gnu: fontconfig: Add a search path for XDG_DATA_DIRS., guix-commits, 2021/10/29
- 112/180: gnu: libcloudproviders-minimal: Introduce minimal variant., guix-commits, 2021/10/29
- 113/180: gnu: gusb-minimal: Introduce minimal variant., guix-commits, 2021/10/29
- 115/180: gnu: inkscape: Remove the legacy 0.92 version., guix-commits, 2021/10/29
- 117/180: gnu: graphviz: Update to 2.49.0., guix-commits, 2021/10/29
- 120/180: gnu: mit-krb5: Absorb 1.19.2 graft., guix-commits, 2021/10/29
- 129/180: gnu: libsoup: Update to 3.0.1., guix-commits, 2021/10/29
- 87/180: gnu: gdb: Normalize indentation., guix-commits, 2021/10/29
- 109/180: gnu: json-glib-minimal: Introduce minimal variant., guix-commits, 2021/10/29