121/150: gnu: python-pymol: Convert #:configure-flags and disable tests.

[guix-commits]

lbraun pushed a commit to branch wip-python-pep517
in repository guix.

commit 35ed330d369d97228428264eafd7abd2dc3f26a9
Author: Lars-Dominik Braun <lars@6xq.net>
AuthorDate: Sat Jan 8 19:16:31 2022 +0100

    gnu: python-pymol: Convert #:configure-flags and disable tests.
    
    * gnu/packages/chemistry.scm (python-pymol)[arguments]: Disable tests,
    convert #:configure-flags to alist, remove obsolete custom 'install phase.
---
 gnu/packages/chemistry.scm | 14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)

diff --git a/gnu/packages/chemistry.scm b/gnu/packages/chemistry.scm
index 292e179922..383952a911 100644
--- a/gnu/packages/chemistry.scm
+++ b/gnu/packages/chemistry.scm
@@ -617,8 +617,9 @@ symmetries written in C.  Spglib can be used to:
         (base32 "08zmfgclkbjkqjpq8xs1mphs1i8rpqj76mcw7m2mrhvma5qj1nr5"))))
     (build-system python-build-system)
     (arguments
-     '(#:configure-flags
-       (list "--glut" "--testing")
+     '(#:tests? #f ; TODO: Needs external test data.
+       #:configure-flags
+       `(@ ("--glut" . "") ("--testing" . ""))
        #:phases
        (modify-phases %standard-phases
          (add-after 'unpack 'make-reproducible
@@ -632,14 +633,7 @@ symmetries written in C.  Spglib can be used to:
                                     "/include/freetype2:"
                                     (assoc-ref inputs "libxml2")
                                     "/include/libxml2:"
-                                    (getenv "CPLUS_INCLUDE_PATH")))))
-         ;; The setup.py script does not support one of the Python build
-         ;; system's default flags, "--single-version-externally-managed".
-         (replace 'install
-           (lambda* (#:key outputs #:allow-other-keys)
-             (invoke "python" "setup.py" "install"
-                     (string-append "--prefix=" (assoc-ref outputs "out"))
-                     "--root=/"))))))
+                                    (getenv "CPLUS_INCLUDE_PATH"))))))))
     (inputs
      (list freetype
            libpng