Re: [PATCH] gnu: musescore: Update to 4.0.

[Nicolas Goaziou]

Hello,

Liliana Marie Prikler <liliana.prikler@gmail.com> writes:

> Am Mittwoch, dem 14.12.2022 um 18:19 +0100 schrieb Nicolas Goaziou:
>>         (snippet
>>          ;; Remove unused libraries.
>>          '(begin
>>             (for-each delete-file-recursively
>> -                     '("thirdparty/freetype"
>> -                       "thirdparty/openssl"
>> -                       "thirdparty/portmidi"
>> -                       "thirdparty/qt-google-analytics"))))))
>> +                     '("thirdparty/freetype"))))))

> I'd prefer if we unbundled more rather than less on updates.

Just to be clear, the removed entries refer to directories that no
longer exist upstream. Therefore we are not bundling now anything that
was unbundled before. I think I mentioned it in the commit message.

However, I agree there is room for improvement in this part. We could
list what should be preserved and delete the rest.

That's not a priority for the time being because I realized the package
is not even building! NB: the software is too large for my laptop to
compile, so I notice build failures only when they appear on Cuirass. In
any case the error is the following:

validating RUNPATH of 2 binaries in "/gnu/store/…-musescore-4.0/bin"...
/gnu/store/…-musescore-4.0/bin/.crashpad_handler-real: error: depends on 
'libcrypto.so.1.1', which cannot be found in RUNPATH ()
/gnu/store/…-musescore-4.0/bin/.crashpad_handler-real: error: depends on 
'libssl.so.1.1', which cannot be found in RUNPATH ()
/gnu/store/…-musescore-4.0/bin/.crashpad_handler-real: error: depends on 
'libz.so.1', which cannot be found in RUNPATH ()
/gnu/store/…-musescore-4.0/bin/.crashpad_handler-real: error: depends on 
'libstdc++.so.6', which cannot be found in RUNPATH ()
/gnu/store/…-musescore-4.0/bin/.crashpad_handler-real: error: depends on 
'ld-linux-x86-64.so.2', which cannot be found in RUNPATH ()

I don't know how to fix those. I guess I need to add some more packages
to inputs.

>>      (build-system qt-build-system)
>>      (arguments
>>       `(#:configure-flags
>> -       `("-DBUILD_TELEMETRY_MODULE=OFF" ;don't phone home
>> -         "-DBUILD_WEBENGINE=OFF"
>> -         "-DDOWNLOAD_SOUNDFONT=OFF"
>> +       `("-DDOWNLOAD_SOUNDFONT=OFF"

> Looking at [1], it appears as though parts of the telemetry module have
> been transferred into "diagnostics".

AFAIU, the "telemetry" part is now handled by bundled Crashpad client.
I saw that we kept bundling this module in qtwebengine, so I assumed it
was also fine here.

There is a CMake option to avoid building it, AFAIR. Unfortunately, the
package doesn't build with this flag either. See
<https://github.com/musescore/MuseScore/issues/15164>.

> It also appears as though precompiled binaries are checked into git.

I did not notice this. Do you know what they are and how to remove them?

> Is enough care taken to remove those?

I'm taking as much care as I can, given my knowledge and skills.

Regards,
-- 
Nicolas Goaziou