guix-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[shepherd] 06/07: service: 'make-systemd-destructor' returns #f once it


From: Ludovic Courtès
Subject: [shepherd] 06/07: service: 'make-systemd-destructor' returns #f once it has closed ports.
Date: Fri, 24 Mar 2023 13:31:41 -0400 (EDT)

civodul pushed a commit to branch master
in repository shepherd.

commit 4822bf1445a1b739275b48117468574f8ba000ab
Author: Ludovic Courtès <ludo@gnu.org>
AuthorDate: Fri Mar 24 14:56:18 2023 +0100

    service: 'make-systemd-destructor' returns #f once it has closed ports.
    
    Previously it would return a truth value, leading to misleading
    "Service ~a might have failed to stop." messages.
    
    * modules/shepherd/service.scm (make-systemd-destructor): Return #f
    after calling 'close-port'.
---
 modules/shepherd/service.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/modules/shepherd/service.scm b/modules/shepherd/service.scm
index aaa7c85..f678ab6 100644
--- a/modules/shepherd/service.scm
+++ b/modules/shepherd/service.scm
@@ -2071,7 +2071,8 @@ This must be paired with @code{make-systemd-destructor}."
       ((? integer? pid)
        (destroy pid))
       (((_ . (? port? socks)) ...)
-       (for-each close-port socks)))))
+       (for-each close-port socks)
+       #f))))
 
 
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]