guix-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

78/244: gnu: go-1.19: Skip 2 gccgo tests.


From: guix-commits
Subject: 78/244: gnu: go-1.19: Skip 2 gccgo tests.
Date: Wed, 12 Apr 2023 08:47:23 -0400 (EDT)

apteryx pushed a commit to branch staging
in repository guix.

commit 3aea350e1644770d31c522f53cce241593174276
Author: Efraim Flashner <efraim@flashner.co.il>
AuthorDate: Wed Apr 5 18:17:12 2023 +0300

    gnu: go-1.19: Skip 2 gccgo tests.
    
    * gnu/packages/golang.scm (go-1.19)[arguments]: Add a phase to skip two
    tests depending on specific versions of gccgo.
---
 gnu/packages/golang.scm | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 89f2192274..9c8decda61 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -905,6 +905,17 @@ in the style of communicating sequential processes 
(@dfn{CSP}).")
      (substitute-keyword-arguments (package-arguments go-1.18)
        ((#:phases phases)
         #~(modify-phases #$phases
+            ;; These are recurring test failures, depending on having a new
+            ;; enough version of gccgo.  gccgo-12.2 fails with go-1.19.7.
+            ;; https://github.com/golang/go/issues/22224
+            ;; https://github.com/golang/go/issues/25324
+            (add-after 'unpack 'skip-TestGoPathShlibGccgo-tests
+              (lambda _
+                (substitute* "misc/cgo/testshared/shared_test.go"
+                  (("TestGoPathShlibGccgo.*" all)
+                   (string-append all "\n        
t.Skip(\"golang.org/issue/22224\")\n"))
+                  (("TestTwoGopathShlibsGccgo.*" all)
+                   (string-append all "\n        
t.Skip(\"golang.org/issue/22224\")\n")))))
             (replace 'install-doc-files
               (lambda _
                 (for-each (lambda (file)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]