guix-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[no subject]


From: Ludovic Courtès
Date: Tue, 5 Sep 2023 09:26:27 -0400 (EDT)

branch: master
commit 0930669024a267888103b81f345e5b6aca4c0e84
Author: Ludovic Courtès <ludo@gnu.org>
AuthorDate: Tue Sep 5 15:05:09 2023 +0200

    templates: Fix broken evaluation display on the spec page.
    
    Fixes a bug introduced in c445d2d642765f9589313e9ccdd826ef9bf71432
    whereby we’d call ‘evaluation-badges’ with #f as its first argument, due
    to the last of a summary for LAST-EVAL.
    
    * src/cuirass/templates.scm (specifications-table): When
    LAST-EVAL-STATUS-OK? is false, call ‘broken-evaluation-badge’.
---
 src/cuirass/templates.scm | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/cuirass/templates.scm b/src/cuirass/templates.scm
index c3cfaf5..a676439 100644
--- a/src/cuirass/templates.scm
+++ b/src/cuirass/templates.scm
@@ -407,9 +407,12 @@ system whose names start with " (code "guile-") ":" (br)
                                ,(scheduled-build-badge
                                  (evaluation-summary-scheduled summary)))))
                            ((and last-eval (not last-eval-status-ok?))
+                            ;; LAST-EVAL is broken so it's missing from
+                            ;; SUMMARIES.
                             `((center
-                               ,@(evaluation-badges
-                                  (eval-summary last-eval) #f))))
+                               ,@(broken-evaluation-badge
+                                  (evaluation-id last-eval)
+                                  (evaluation-current-status last-eval)))))
                            (else '()))))
                      (td
                       ,@(let* ((name (specification-name spec))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]