[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
12/24: system: vm: Remove unused variable.
From: |
guix-commits |
Subject: |
12/24: system: vm: Remove unused variable. |
Date: |
Fri, 29 Sep 2023 06:10:54 -0400 (EDT) |
janneke pushed a commit to branch hurd-team
in repository guix.
commit 60cc5121acd7097ae4688177011e92f63c417c46
Author: Ludovic Courtès <ludo@gnu.org>
AuthorDate: Fri Sep 22 14:54:02 2023 +0200
system: vm: Remove unused variable.
This is a followup to 05a9d1f378e2e13e8f759be926ea368358afc27c, which
removed its sole user.
* gnu/system/vm.scm (%linux-vm-file-systems): Remove.
(mapping->file-system): Add comment about “cache=loose”.
---
gnu/system/vm.scm | 41 ++++++-----------------------------------
1 file changed, 6 insertions(+), 35 deletions(-)
diff --git a/gnu/system/vm.scm b/gnu/system/vm.scm
index b7bccd72a4..70f7b00116 100644
--- a/gnu/system/vm.scm
+++ b/gnu/system/vm.scm
@@ -87,41 +87,6 @@
;; conservative default.
(define %default-msize-value (* 100 (expt 2 20))) ;100 MiB
-(define %linux-vm-file-systems
- ;; File systems mounted for 'derivation-in-linux-vm'. These are shared with
- ;; the host over 9p.
- ;;
- ;; The 9p documentation says that cache=loose is "intended for exclusive,
- ;; read-only mounts", without additional details. It's much faster than the
- ;; default cache=none, especially when copying and registering store items.
- ;; Thus, use cache=loose, except for /xchg where we want to ensure
- ;; consistency.
- (list (file-system
- (mount-point (%store-prefix))
- (device "store")
- (type "9p")
- (needed-for-boot? #t)
- (flags '(read-only))
- (options (format #f "trans=virtio,cache=loose,msize=~a"
- %default-msize-value))
- (check? #f))
- (file-system
- (mount-point "/xchg")
- (device "xchg")
- (type "9p")
- (needed-for-boot? #t)
- (options (format #f "trans=virtio,msize=~a" %default-msize-value))
- (check? #f))
- (file-system
- (mount-point "/tmp")
- (device "tmp")
- (type "9p")
- (needed-for-boot? #t)
- (options (format #f "trans=virtio,cache=loose,msize=~a"
- %default-msize-value))
- (check? #f))))
-
-
;;;
;;; VMs that share file systems with the host.
;;;
@@ -145,6 +110,12 @@
(device (file-system->mount-tag source))
(type "9p")
(flags (if writable? '() '(read-only)))
+
+ ;; The 9p documentation says that cache=loose is "intended for
+ ;; exclusive, read-only mounts", without additional details. It's
+ ;; faster than the default cache=none, especially when copying and
+ ;; registering store items. Thus, use cache=loose, except for writable
+ ;; mounts, to ensure consistency.
(options (string-append "trans=virtio"
(if writable? "" ",cache=loose")
",msize=" (number->string
%default-msize-value)))
- branch hurd-team created (now 3a54dc49ad), guix-commits, 2023/09/29
- 01/24: hurd: Support system init in /libexec/runsystem., guix-commits, 2023/09/29
- 02/24: hurd-boot: Support system init: Create essential device nodes., guix-commits, 2023/09/29
- 07/24: gnu: Add libc-locales-for-target and glibc-locales/hurd., guix-commits, 2023/09/29
- 04/24: DRAFT hurd: Support second boot., guix-commits, 2023/09/29
- 05/24: DRAFT hurd-boot: Support second boot., guix-commits, 2023/09/29
- 06/24: DRAFT system: examples: Add devel-hurd.tmpl., guix-commits, 2023/09/29
- 14/24: services: hurd-vm: Use the default SSH port number., guix-commits, 2023/09/29
- 15/24: gnu: glibc-utf8-locales: Reintroduce input labels., guix-commits, 2023/09/29
- 12/24: system: vm: Remove unused variable.,
guix-commits <=
- 13/24: secret-service: Increase default handshake timeout., guix-commits, 2023/09/29
- 03/24: system: hurd: Add swap-services to hurd-default-essential-services., guix-commits, 2023/09/29
- 11/24: Revert "system: bare-hurd.tmpl: Include glibc-2.33 locales in cross-build.", guix-commits, 2023/09/29
- 08/24: DRAFT daemon: Support chroot builds on GNU/Hurd., guix-commits, 2023/09/29
- 09/24: Revert "DRAFT daemon: Support chroot builds on GNU/Hurd.", guix-commits, 2023/09/29
- 10/24: system: bare-hurd.tmpl: Include glibc-2.33 locales in cross-build., guix-commits, 2023/09/29
- 17/24: services: guix: Support declarative offloading setup., guix-commits, 2023/09/29
- 18/24: services: childhurd: Authorize the childhurd’s key on the host., guix-commits, 2023/09/29
- 19/24: services: hurd-vm: ‘image’ field has to be an <image> record., guix-commits, 2023/09/29
- 20/24: tests: hurd-vm: Remove custom disk image configuration., guix-commits, 2023/09/29