[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add libtermkey, vis and lua-lpeg packages
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH] Add libtermkey, vis and lua-lpeg packages |
Date: |
Sun, 04 Dec 2016 22:24:52 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Hello, and welcome!
Thanks for sharing patches! They are almost ready to be applied, I’ll
just point out a few issues. You can look at
<https://www.gnu.org/software/guix/manual/html_node/Submitting-Patches.html>
for more info.
address@hidden skribis:
> From 792a9ff128f397bcf9eac1f113e84ebe29f2eb2f Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Jos=C3=A9=20Miguel=20S=C3=A1nchez=20Garc=C3=ADa?=
> <address@hidden>
> Date: Fri, 2 Dec 2016 23:39:08 +0100
> Subject: [PATCH] Add vis, libtermkey and lua-lpeg packages
As noted in the page above, we use “GNU ChangeLog” style for commit
logs. You can see examples in ‘git log’.
> ---
> gnu/packages/libtermkey.scm | 36 ++++++++++++++++++++++++++++++++++++
> gnu/packages/lua-lpeg.scm | 33 +++++++++++++++++++++++++++++++++
> gnu/packages/vis.scm | 37 +++++++++++++++++++++++++++++++++++++
Please make one patch per package.
> +++ b/gnu/packages/libtermkey.scm
> @@ -0,0 +1,36 @@
> +(define-module (gnu packages libtermkey)
Could you add the license header (as in the other files) with a
copyright line for yourself?
> + (description (string-append
> + "Libtermkey handles all the necessary logic to recognise special keys,
> "
> + "UTF-8 combining, and so on, with a simple interface."))
Please use a literal string instead of ‘string-append’. That way the
description will be picked up for translation.
Also, if you haven’t done already, make sure to run ‘guix lint’ for
these packages. It’s usually a good way to catch tiny issues.
Could you send updated patches? If minor problems remain we can fix
them for you if you want.
Thank you!
Ludo’.