[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: Add denemo.
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH] gnu: Add denemo. |
Date: |
Fri, 09 Dec 2016 23:33:32 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
address@hidden (Ludovic Courtès) skribis:
> Kei Kebreau <address@hidden> skribis:
[...]
>> Everything seems fine except for grafting (i.e. disabling grafting
>> renders the issue invisible). For some reason, "find-files"
>> does not recognize a file with a Unicode-encoded filename when called
>> inside "rename-matching-files" from guix/build/graft.scm. When
>> "find-files" is used on its own, the file is recognized properly.
>> Is anyone familiar with the grafting code available to help figure out
>> what is happening to the file name?
>
> Problem is that the grafting code (‘graft-derivation/shallow’ in (guix
> grafts)) is running in the C locale, so it expects file names to be
> ASCII. I’ll look into it.
Looking closer into it, may I suggest renaming the file in question?
:-)
The real fix would be for ‘graft-derivation/shallow’ to return a
dependency that depends on ‘glibc-utf8-locales’, but that can create
bootstrapping issues (also we don’t want unit tests to trigger a build
of ‘glibc-utf8-locales’ and everything before that).
Ludo’.