guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: branch core-updates updated: packages: Fix 'base32' used before defi


From: Maxim Cournoyer
Subject: Re: branch core-updates updated: packages: Fix 'base32' used before definition warning.
Date: Mon, 11 Jan 2021 08:16:30 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)

Hi Ludovic!

Ludovic Courtès <ludo@gnu.org> writes:

> Hi Maxim,
>
> guix-commits@gnu.org skribis:
>
>> commit 31ebecf73dadb51ccc72053f54dee36c93a2d0ab
>> Author: Maxim Cournoyer <maxim.cournoyer@gmail.com>
>> AuthorDate: Sun Jan 10 08:42:42 2021 -0500
>>
>>     packages: Fix 'base32' used before definition warning.
>>
>>     Before this change, compiling the module would emit the following 
>> message:
>>     "guix/packages.scm:213:25: warning: macro `base32' used before 
>> definition".
>>
>>     * guix/packages.scm (define-compile-time-decoder)
>>     (base32, base64): Move definitions to the top of the module.
>
> To avoid merge conflicts down the road, could you apply it to ‘master’
> as well?  (It’s fine to have it on ‘master’ as it doesn’t trigger any
> rebuild.)

Thanks for letting me know; I was under the impression that the
guix/packages.scm module as a whole would be used in the computation of
any package's derivation hash.  I'm happy to learn it's actually smarter
than this :-).

Cherry-picked to master with commit
8152fd1af551f4bcec2ef59243264c10ff48daea.

Thank you,

Maxim



reply via email to

[Prev in Thread] Current Thread [Next in Thread]