[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: A "cosmetic changes" commit that removes security fixes
From: |
Léo Le Bouter |
Subject: |
Re: A "cosmetic changes" commit that removes security fixes |
Date: |
Fri, 23 Apr 2021 21:33:07 +0200 |
User-agent: |
Evolution 3.34.2 |
On Fri, 2021-04-23 at 15:18 -0400, Leo Famulari wrote:
> Léo and Raghav, you need to keep learning our workflow around
> security
> updates. It's not okay to remove security patches and later update a
> package to a fixed version in a different commit. `git rebase` is the
> tool to learn for cases like this one.
I knew about this but I didnt feel like telling Raghav to do yet
another rebase. I felt like Raghav was taking on with so much already.
The rebase was specially complicated because Raghav's commit changed
indentation, git has bad quite bad UX for cases like these. At the time
I had lots of things to handle also and couldnt spend lots of time on
it myself. I didnt feel like blocking the merge of these patches for
commit history was worth it at all. Such blocking could have hindered
the GNOME upgrade effort even more. Thankfully now there's lots of
energy being put to it, at the time there wasnt anyone else than Raghav
and me.
Léo
signature.asc
Description: This is a digitally signed message part
- Re: A "cosmetic changes" commit that removes security fixes, (continued)
- Re: A "cosmetic changes" commit that removes security fixes, Christopher Baines, 2021/04/22
- Re: A "cosmetic changes" commit that removes security fixes, Leo Prikler, 2021/04/22
- Re: A "cosmetic changes" commit that removes security fixes, Mark H Weaver, 2021/04/22
- Re: A "cosmetic changes" commit that removes security fixes, Maxim Cournoyer, 2021/04/23
- Re: A "cosmetic changes" commit that removes security fixes, Raghav Gururajan, 2021/04/23
- Re: A "cosmetic changes" commit that removes security fixes, Maxim Cournoyer, 2021/04/23
- Re: A "cosmetic changes" commit that removes security fixes, Raghav Gururajan, 2021/04/23
- Re: A "cosmetic changes" commit that removes security fixes, Léo Le Bouter, 2021/04/23
- Re: A "cosmetic changes" commit that removes security fixes, Leo Prikler, 2021/04/23
- Re: A "cosmetic changes" commit that removes security fixes, Leo Famulari, 2021/04/23
- Re: A "cosmetic changes" commit that removes security fixes,
Léo Le Bouter <=
- Re: A "cosmetic changes" commit that removes security fixes, Leo Famulari, 2021/04/23
- Re: A "cosmetic changes" commit that removes security fixes, Giovanni Biscuolo, 2021/04/26
- Re: A "cosmetic changes" commit that removes security fixes, Leo Famulari, 2021/04/26
- Re: A "cosmetic changes" commit that removes security fixes, Giovanni Biscuolo, 2021/04/26
- Re: A "cosmetic changes" commit that removes security fixes, Leo Famulari, 2021/04/26
- Re: A "cosmetic changes" commit that removes security fixes, Mark H Weaver, 2021/04/24
- Re: A "cosmetic changes" commit that removes security fixes, Léo Le Bouter, 2021/04/26
- Re: A "cosmetic changes" commit that removes security fixes, Tobias Geerinckx-Rice, 2021/04/26
- Re: A "cosmetic changes" commit that removes security fixes, Ludovic Courtès, 2021/04/26
- Re: A "cosmetic changes" commit that removes security fixes, Pjotr Prins, 2021/04/26