[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: branch master updated: gnu: Add html2text.
From: |
Tobias Geerinckx-Rice |
Subject: |
Re: branch master updated: gnu: Add html2text. |
Date: |
Tue, 27 Apr 2021 14:15:26 +0200 |
Guillaume,
guix-commits@gnu.org 写道:
gnu: Add html2text.
Thanks!
This package is good but would've benefited from review. Please
submit all non-trivial patches to guix-patches@gnu.org first (if
you did, I couldn't find it). We've been too lax about this in
the past, myself certainly included.
I've pushed some additional fixes[0]:
- The configure script is home-grown and simply ‘eval’s all
command-line arguments in the hope that they are variable
assignments. Our defaults confuse it greatly:
--8<---------------cut here---------------start------------->8---
configure flags:
("CONFIG_SHELL=/gnu/store/pwcp239kjf7lnj5i4lkdzcfcxwcfyk72-bash-minimal-5.0.16/bin/bash"
"SHELL=/gnu/store/pwcp239kjf7lnj5i4lkdzcfcxwcfyk72-bash-minimal-5.0.16/bin/bash"
"--prefix=/gnu/store/bblcx4gcchp7a5dp2y51wbmlh0212xz6-html2text-2.0.1_pre-1.05364c1"
"--enable-fast-install" "--build=x86_64-unknown-linux-gnu")
./configure: line 25: eval: --: invalid option
eval: usage: eval [arg ...]
./configure: line 25: eval: --: invalid option
eval: usage: eval [arg ...]
--8<---------------cut here---------------end--------------->8---
Upstream didn't bother to add error checking, but we should still
call it in the expected manner.
- Use #:make-flags etc. whenever possible rather than patching
build scripts.
- Cross-compilation was broken. Building with
--target=aarch64-linux-gnu produced an x86_64 binary. Fixed by
passing CXX to ./configure in the non-standard manner above.
- I noticed some 4-clause BSD headers & added them to the license
field. This is purely informative: the result remains GPL2+.
Kind regards,
T G-R
[0]:
https://git.savannah.gnu.org/cgit/guix.git/commit/?id=e009b8d7126531a2983701413c5b97e620e495e4
and parents
signature.asc
Description: PGP signature
- Re: branch master updated: gnu: Add html2text.,
Tobias Geerinckx-Rice <=