[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: cleaning up some minor things
From: |
Ludovic Courtès |
Subject: |
Re: cleaning up some minor things |
Date: |
Sun, 15 May 2022 23:18:53 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Hello,
Ricardo Wurmus <rekado@elephly.net> skribis:
> “guix/scripts/pull.scm” imports WITH-FILE-LOCK/NO-WAIT from (guix build
> syscalls) but doesn’t use it. Can we remove that?
Yes.
> “guix/store/deduplication.scm” defines a variant of DUMP-PORT with this
> comment:
>
> ;; TODO: Remove once 'dump-port' in (guix build utils) has an optional
> 'len'
> ;; parameter.
>
> The variant in (guix build utils) already supports that optional
> argument. Can we remove the variant in (guix store deduplication)?
Yes, looks like it.
Go for it!
Thanks,
Ludo’.