[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: guix lint false positives and RFC patch
|
From: |
Ludovic Courtès |
|
Subject: |
Re: guix lint false positives and RFC patch |
|
Date: |
Thu, 03 Nov 2022 16:20:45 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) |
Vagrant Cascadian <vagrant@debian.org> skribis:
> --- a/guix/lint.scm
> +++ b/guix/lint.scm
> @@ -313,7 +313,8 @@ (define (tests-explicitly-enabled?)
> '()))
>
> (define (properly-starts-sentence? s)
> - (string-match "^[(\"'`[:upper:][:digit:]]" s))
> + (string-match "^[(\"'`[:upper:][:digit:]]"
> + (string-replace-substring s "@code{" "")))
An identifier in @code or file name in @file may legitimately start with
a lower-case letter so I don’t think we should try to prevent that.
However, maybe we could change the regexp above to something that
accepts @ or some other non-letter character at the start?
Ludo’.