[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Patch Review Flow
From: |
Efraim Flashner |
Subject: |
Re: Patch Review Flow |
Date: |
Tue, 7 Nov 2023 10:56:05 +0200 |
On Mon, Nov 06, 2023 at 07:51:58AM +0000, Christopher Baines wrote:
>
> "jgart" <jgart@dismail.de> writes:
>
> > Does anyone follow this workflow for reviewing patches?
> >
> > git clone https://git.guix-patches.cbaines.net/guix-patches/
> > git checkout issue-xxxxx
> > git format-patch ...
> > # then in the development checkout of Guix:
> > git am ...; make; ./pre-inst-env guix build
> >
> > Should we document it in the manual?
> >
> > Does anyone follow a workflow that is more efficient than the above?
>
> I have the guix-patches repository as a remote, which I then cherry pick
> from (via Magit), which makes it quick and easy to apply patches.
I also have the guix-patches repository as a remote, and then I use tig
to look at the different branches there. I haven't checked to see if
it's possible to use git am or git cherry-pick from tig's interface so
I'm doing that one by one.
--
Efraim Flashner <efraim@flashner.co.il> רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
signature.asc
Description: PGP signature