Re: QA is back, who wants to review patches?

[Christopher Baines]

Tanguy LE CARROUR <tanguy@bioneland.org> writes:

> Hi Chris,
>
> First of, thanks (again) for everything that you’ve done with QA!
> It looks great!
>
>
> Quoting Christopher Baines (2024-02-09 11:44:11)
>> Let me know if you have any comments or questions!
>
> Unfortunately, I have some (stupid) questions!
>
> I decided to give it a try and I picked at random a patch that
> was supposed to be an easy one:
>
> ```
> [bug#68590] gnu: notmuch: update to version 0.38.2
> ```
>
> It’s mark as "green" *ie* important checks passing, but…
> it does not even apply?! Actually, it’s for a good reason:
> the exact same patch has been applied 2 weeks ago by
> Nicolas Goaziou as #9b65b60b97.
>
> The patch is still open on Debbugs. I guess it should be closed, right?
>
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68590
>
> I guess it got is "green" status on QA before other patch made it to
> master.
>
> Can I safely close it?!

Yep, this unfortunately looks like a case where there was a duplication
of effort and the original patch got ignored.

It looks like the issue has been closed now.

QA can spot when patches don't apply, but it doesn't test for that
regularly at the moment.

signature.asc
Description: PGP signature