guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#27307: [PATCH] gnu: unshield: Remove incorrect '"'.


From: Marius Bakke
Subject: bug#27307: [PATCH] gnu: unshield: Remove incorrect '"'.
Date: Sat, 10 Jun 2017 17:59:33 +0200
User-agent: Notmuch/0.24.2 (https://notmuchmail.org) Emacs/25.2.1 (x86_64-unknown-linux-gnu)

address@hidden writes:

> * gnu/packages/compression.scm: Remove incorrect '"'.

Nit-pick: it should say "* gnu/packages/compression.scm (unshield): ..."

[...]

> -           (uri (string-append "https://www.dropbox.com/s/8r4b6752swe3nhu/\";
> +           (uri (string-append "https://www.dropbox.com/s/8r4b6752swe3nhu/\
>  unshield-avigomanager11b22.zip?dl=1"))

I guess you can also remove string-append here? Alternatively, quoting the
next line and indenting it would look a little better IMO.

Sorry for the review failure! :-)

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]