guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#27855] [PATCH] gnu: Add rsync service.


From: Oleg Pykhalov
Subject: [bug#27855] [PATCH] gnu: Add rsync service.
Date: Thu, 10 Aug 2017 21:56:17 +0300
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)

Hello Christopher,

Thank you for supporting this patch!

Christopher Baines <address@hidden> writes:

> On Thu, 10 Aug 2017 08:18:20 +0100
> Christopher Baines <address@hidden> wrote:
>
>> I've attached the beginnings of a system test for this. I haven't got
>> as far as actually testing the service directly yet, but I'm going to
>> try testing it, both when running as root, and when not running as
>> root.
>> 
>> A VM start script can be created from this rsync.scm file, by running:
>>   guix system vm gnu/tests/rsync.scm
>> 
>> Also, the test itself can be run by doing:
>>   make check-system TESTS=rsync
>
> I've now got around to actually testing the service. I've attached a
> patch which creates two system tests. One which tests the service with
> the default port, and one with a higher port (I randomly picked 2000).
>
> The default port test currently passes, but the higher port one
> currently fails as the rsync service can't create the PID file.
>
> One option to fix this would be to create a /var/run/rsync directory
> which is owned by the rsyncd user, and then create the PID file
> as /var/run/rsync/pid.

I'll check it later, if you'll not be faster than me.  :-)

> Just let me know if you have any questions?
…

I successfully passed you previous patch test, but the new patch one
with two “ports” fails.

Attachment: txtgioMIbRwt2.txt
Description: Tests log


reply via email to

[Prev in Thread] Current Thread [Next in Thread]