[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#29271] [PATCH 1/1] doc: Split the "Substitutes" section into subsec
From: |
Ludovic Courtès |
Subject: |
[bug#29271] [PATCH 1/1] doc: Split the "Substitutes" section into subsections. |
Date: |
Mon, 20 Nov 2017 23:40:53 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Hello!
Eric Bavier <address@hidden> skribis:
> On Sun, 12 Nov 2017 15:36:44 -0500
> Leo Famulari <address@hidden> wrote:
>
>> On Sun, Nov 12, 2017 at 03:05:58AM -0800, Chris Marusich wrote:
>> > address@hidden
>> > @item --fallback
>> > -When substituting a pre-built binary fails, fall back to building
>> > -packages locally.
>> > +Attempt to build locally instead of issuing an error when substitutes
>> > +are enabled and a substitute is available, but the substitution attempt
>> > +fails (@pxref{Substitution Failure}).
>>
>> I was able to read this smaller change. I think the new sentence is too
>> byzantine. I know what --fallback does but I found this sentence hard to
>> understand.
>
> Same here.
[...]
> IMHO, the original text is just fine, and succinctly conveys the
> origin of the option name. Perhaps just add the cross reference.
I agree, but I’m biased. ;-)
Apart from that, the rest LGTM. I have one minor request:
> +* Hydra:: One particular source of substitutes.
I would call this “Official Substitute Server” or something like that,
and not mention Hydra (as a proper noun) since we’re not defining it,
and since the server won’t run Hydra forever.
With these two changes, I think you can push.
Thanks for improving the manual!
Ludo’.
[bug#29271] [PATCH 1/1] doc: Split the "Substitutes" section into subsections., Leo Famulari, 2017/11/12
[bug#29271] [PATCH 1/1] doc: Split the "Substitutes" section into subsections., myglc2, 2017/11/13
[bug#29271] [PATCH 0/1] Improve the "Substitutes" documentation, Adonay Felipe Nogueira, 2017/11/12
bug#29271: Status: [PATCH 0/1] Improve the "Substitutes" documentation, Chris Marusich, 2017/11/21