[bug#29732] [PATCH 0/1] Add a DHCP daemon service

[Christopher Baines]

Chris Marusich writes:

> Hi,
>
> The following patch adds a DHCP daemon service.  It applies cleanly to
> commit 341bddb31542d03bef35b1234e6e9466be337798.
>
> I haven't found the time to add system tests yet, and I'm not sure how
> easy it would be to do that (wouldn't such a system test require at
> least two marionetted VMs?  Or is it possible to do it with just
> one?).  Any thoughts about how to do that would be welcome.
>
> In addition, I decided not to provide any kind of Guile scheme
> representation for the daemon's config file, since that was the
> quickest way for me to get a working DHCP daemon service.  I think it
> makes sense to let a user specify a config file explicitly, like this
> patch does.  I also think it would be neat to provide a way to
> configure the daemon in Guile scheme, like we do for other services
> such as openssh.  Any thoughts on this front would be welcome, too.
>
> Chris Marusich (1):
>   services: Add dhcpd-service-type and <dhcpd-configuration>.
>
>  doc/guix.texi               | 17 +++++++++++
>  gnu/services/networking.scm | 72 
> +++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 89 insertions(+)

I had a quick look at the patch, and it looks good to me.

A system test would be nice. I think the important thing to test is the
Guix part of the service, so if it's possible to get it to start on a
VM, I think just checking the status of the shepherd service would be a
good test.

I think not providing a Guile configuration approach is fine as well.

Thanks,

Chris