[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#29951] [PATCH] WIP guix: Add wrap-script.
From: |
Hartmut Goebel |
Subject: |
[bug#29951] [PATCH] WIP guix: Add wrap-script. |
Date: |
Wed, 3 Jan 2018 14:59:27 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
This code is over-changeling my scheme knowledge :-) Thus just a few
comments:
> + (false-if-exception
> + (and=> (regexp-exec coding-line-regex
> (read-line p))
> + (lambda (m) (match:substring m
> 0)))))))))
When using emacs, this line can also contain other local variable
definitions. What about keeping the whole line?
> + (when interpreter
> + (let* ((header (format #f "\
> +#!~a --no-auto-compile
> +#!#; ~a
> +#\\-~s
> +#\\-~s
> +"
> + (which "guile")
> + (or coding-line "Guix wrapper")
> + (cons 'begin (map update-env vars))
> + `(apply execl ,interpreter
> + (car (command-line))
> + (command-line))))
Does this take care of proper quoting the string-values?
> + (call-with-ascii-input-file prog
Does this work if the file contains non-ascii characters, e.g. \xf0
(assuming "ascii" means 0-127 only)?
--
Regards
Hartmut Goebel
| Hartmut Goebel | address@hidden |
| www.crazy-compilers.com | compilers which you thought are impossible |