guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#29932] [PATCH v2 2/2] system: Rename operating-system-user-kernel-a


From: Ludovic Courtès
Subject: [bug#29932] [PATCH v2 2/2] system: Rename operating-system-user-kernel-arguments to operating-system-kernel-arguments.
Date: Fri, 12 Jan 2018 15:06:42 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)

Hi,

Danny Milosavljevic <address@hidden> skribis:

> * gnu/system.scm (operating-system-user-kernel-arguments): Rename to...
> (operating-system-kernel-arguments): ... this.
> <operating-system>: Adapt to new name.
> (operating-system-boot-parameters): Adapt to new name.
> * gnu/system/vm.scm (system-qemu-image/shared-store-script): Adapt to new 
> name.
> * gnu/tests.scm (marionette-operating-system): Adapt to new name.
> ---
>  gnu/system.scm    | 6 +++---
>  gnu/system/vm.scm | 2 +-
>  gnu/tests.scm     | 2 +-
>  3 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/gnu/system.scm b/gnu/system.scm
> index 51f45f6ac..92b3e2959 100644
> --- a/gnu/system.scm
> +++ b/gnu/system.scm
> @@ -74,7 +74,7 @@
>              operating-system-kernel
>              operating-system-kernel-file
>              operating-system-boot-kernel-arguments
> -            operating-system-user-kernel-arguments
> +            operating-system-kernel-arguments

I’m a bit lost: in my tree I don’t have
‘operating-system-boot-kernel-arguments’.  Is it still pending?

Otherwise my only question is whether it’s a good idea to move away from
the ‘user-’ convention.  On one hand, it’s the convention we also have
for services (‘-user-services’ vs. ‘-services’), so it would be a good
thing to remain consistent.  OTOH, what you propose is maybe clearer.

Thoughts?

Thanks,
Ludo’.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]