[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#30439] [PATCH] gnu: Add qqc2-desktop-style.
From: |
Marius Bakke |
Subject: |
[bug#30439] [PATCH] gnu: Add qqc2-desktop-style. |
Date: |
Tue, 13 Feb 2018 23:11:05 +0100 |
User-agent: |
Notmuch/0.26 (https://notmuchmail.org) Emacs/25.3.1 (x86_64-pc-linux-gnu) |
Hartmut Goebel <address@hidden> writes:
> * gnu/packages/kde-frameworks.scm (qqc2-desktop-style): New
> variable.
[...]
> +(define-public qqc2-desktop-style
> + (package
> + (name "qqc2-desktop-style")
> + (version "5.42.0")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append
> + "mirror://kde/stable/frameworks/"
> + (version-major+minor version) "/"
> + name "-" version ".tar.xz"))
> + (sha256
> + (base32
> + "1arlfhcshfs11pgf87jzjgln1p711zlx0v0q014740mbzb9g5wnk"))))
> + (build-system cmake-build-system)
> + (native-inputs
> + `(("extra-cmake-modules" ,extra-cmake-modules)
> + ("pkg-config" ,pkg-config)))
> + (inputs
> + `(("kauth" ,kauth)
> + ("kconfigwidgets" ,kconfigwidgets) ;; optional
> + ("kcoreaddons" ,kcoreaddons)
> + ("kiconthemes" ,kiconthemes) ;; optional
Nit-pick: only a single semicolon for inline comments.
> + ("kirigami" ,kirigami)
> + ("qtbase" ,qtbase)
> + ("qtdeclarative" ,qtdeclarative)))
> + (home-page "https://community.kde.org/Frameworks")
> + (synopsis "QtQuickControls2 style that integrates with the desktop")
> + (description "This is a style for QtQuicControls2 which is using
> QWidget's
^^^ missing 'k'
> +QStyle to paint the controls in order to give it a native look and feel.
> +")
This can be moved to the end of the previous line.
> + (license (list license:gpl3+ license:lgpl2.1+))))
I'm not familiar with KDE, is everything dual licensed as
GPL3+/LGPL2.1+? If not, please add a comment explaining what is covered
by which license (or clarify whether it's dual-licensed).
Otherwise LGTM.
signature.asc
Description: PGP signature