[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#31514] [PATCH 09/21] gnu: Add emacs-gif-screencast.
From: |
Pierre Neidhardt |
Subject: |
[bug#31514] [PATCH 09/21] gnu: Add emacs-gif-screencast. |
Date: |
Sat, 02 Jun 2018 18:53:24 +0200 |
User-agent: |
mu4e 1.0; emacs 26.1 |
Ludovic Courtès <address@hidden> writes:
> Pierre Neidhardt <address@hidden> skribis:
>
>> * gnu/packages/emacs.scm (emacs-gif-screencast): New variable.
>
> [...]
>
>> + (package
>> + (name "emacs-gif-screencast")
>> + (version "20180309")
>> + (source
>> + (origin
>> + (method url-fetch)
>> + (uri (string-append
>> + "https://github.com/Ambrevar/emacs-gif-screencast/archive/"
>> + "825e606950ec842304bf75cf85baef707b853b03"
>> + ".tar.gz"))
>
> Could you use the usual scheme for version numbers of Git snapshots
> (info "(guix) Version Numbers")?
I followed the form of emacs-zotxt that was just packaged.
emacs-gif-screencast, like many other Emacs packages, has no version
number.
Do you suggest something like
--8<---------------cut here---------------start------------->8---
(let ((commit ...))
; ...
(gitversion "20180309" "1" commit)
--8<---------------cut here---------------end--------------->8---
?
>> + (propagated-inputs
>> + `(("scrot" ,scrot)
>> + ("imagemagick" ,imagemagick)
>> + ("gifsicle" ,gifsicle)))
>
> Instead of propagating these, which could “pollute” the user’s profile,
> could you hardcode the absolute file names of these programs in the .el
> files? See how this is done for EMMS, for instance.
Ack.
--
Pierre Neidhardt
signature.asc
Description: PGP signature