[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#32358] Add pcscd service
From: |
Chris Marusich |
Subject: |
[bug#32358] Add pcscd service |
Date: |
Tue, 14 Aug 2018 22:55:30 -0700 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Hi Clément and Arun,
Clément, your explanation makes sense. With that information, I now
understand why it isn't necessary to use make-forkexec-constructor in
this case. Thank you for taking the time to explain it in detail!
Arun Isaac <address@hidden> writes:
> I have finished work on the tests too. Please find attached the updated
> patch.
Awesome!
> +(define* (run-pcscd-test)
> + "Run tests of 'pcscd-service-type'."
> + (define os
> + (marionette-operating-system
> + %pcscd-os
> + #:imported-modules '((gnu services herd))))
If you use the #:requirements keyword argument to
marionette-operating-system, you can guarantee that the marionette
service will start up after the pcscd service. This would be good in
order to avoid the possibility that you might marionette-eval something
before the pcscd service is started.
With that small change, if the system test passes, I think this is good
to go to master. Thank you for taking the time to work on this and
iterate through the feedback!
--
Chris
signature.asc
Description: PGP signature
- [bug#32358] Add pcscd service, (continued)
- [bug#32358] Add pcscd service, Chris Marusich, 2018/08/10
- [bug#32358] Add pcscd service, Arun Isaac, 2018/08/12
- [bug#32358] Add pcscd service, Arun Isaac, 2018/08/13
- [bug#32358] Add pcscd service, Arun Isaac, 2018/08/13
- [bug#32358] Add pcscd service, Arun Isaac, 2018/08/14
- Message not available
- [bug#32358] Add pcscd service, Chris Marusich, 2018/08/12
- [bug#32358] Add pcscd service, Clément Lassieur, 2018/08/12
- [bug#32358] Add pcscd service, Chris Marusich, 2018/08/13
- [bug#32358] Add pcscd service, Clément Lassieur, 2018/08/13
- [bug#32358] Add pcscd service, Clément Lassieur, 2018/08/13
- [bug#32358] Add pcscd service,
Chris Marusich <=
- [bug#32358] Add pcscd service, Clément Lassieur, 2018/08/15
- bug#32358: Add pcscd service, Arun Isaac, 2018/08/15
[bug#32358] About commit "Avoid assertion violations in maybe_produce_line_number", Kaushal Modi, 2018/08/06