[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#32346] [PATCH 6/6] services: tor: Make it easier to use UNIX socket
From: |
Ludovic Courtès |
Subject: |
[bug#32346] [PATCH 6/6] services: tor: Make it easier to use UNIX sockets. |
Date: |
Mon, 20 Aug 2018 22:09:27 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Chris Marusich <address@hidden> skribis:
> * doc/guix.texi (Networking Services): Document it, and mention that
> tor-service is deprecated.
> * gnu/services/networking.scm (<tor-configuration>) <socks-socket-type>:
> New field.
> (tor-configuration->torrc): When socks-socket-type is 'unix, set
> SocksPort to UNIX domain socket /var/run/tor/socks-sock and set
> UnixSocksGroupWritable to 1.
> * gnu/tests/networking.scm (%tor-os/unix-socks-socket): Instead of using
> a custom config file, just set socks-socket-type to 'unix.
[...]
> +This is the type for a service that runs the @uref{https://torproject.org,
> +Tor} anonymous networking daemon. The service is configured using a
> address@hidden<tor-configuration>} record. By default, the TOR daemon runs
> as the
Please s/TOR/Tor/ in this file.
> address@hidden {Data Type} tor-configuration
> address@hidden @asis
> address@hidden @code{tor} (default: @code{tor})
> +The package that provides the TOR daemon. This package is expected to
> provide
> +the daemon at @file{bin/tor} relative to its output directory. The default
> +package is the @uref{https://www.torproject.org, TOR Project's}
> +implementation.
> address@hidden @code{config-file} (default: @code{(plain-file "empty" "")})
You could skip a line between between each @item for clarity.
Otherwise LGTM.
Thank you for this nice patch series!
Ludo’.
- [bug#32346] [PATCH 1/6] services: tor: Add a system test., (continued)
- [bug#32346] [PATCH 1/6] services: tor: Add a system test., Chris Marusich, 2018/08/02
- [bug#32346] [PATCH 3/6] marionette: Add support for QEMU's "quit" command., Chris Marusich, 2018/08/02
- [bug#32346] [PATCH 2/6] services: tor: Rename activation procedure., Chris Marusich, 2018/08/02
- [bug#32346] [PATCH 5/6] tests: tor: Add more test cases., Chris Marusich, 2018/08/02
- [bug#32346] [PATCH 4/6] marionette: Add wait-for-unix-socket., Chris Marusich, 2018/08/02
- [bug#32346] [PATCH 6/6] services: tor: Make it easier to use UNIX sockets., Chris Marusich, 2018/08/02
- [bug#32346] [PATCH 6/6] services: tor: Make it easier to use UNIX sockets.,
Ludovic Courtès <=
- [bug#32346] [PATCH 1/6] services: tor: Add a system test., Ludovic Courtès, 2018/08/20
- [bug#32346] [PATCH 0/6] TOR via Unix domain SOCKS socket, Nils Gillmann, 2018/08/02
- [bug#32346] [PATCH 0/6] TOR via Unix domain SOCKS socket, Chris Marusich, 2018/08/04