[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#32584] [PATCH] gnu: Add yad.
From: |
Ricardo Wurmus |
Subject: |
[bug#32584] [PATCH] gnu: Add yad. |
Date: |
Mon, 3 Sep 2018 17:57:45 +0200 |
User-agent: |
mu4e 1.0; emacs 26.1 |
Hi,
thanks for the patch!
> gnu/packages/gtk.scm (yad): New variable.
[…]
> +(define-public yad
> + (package
> + (name "yad")
> + (version "0.40.3")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append
> "https://github.com/v1cont/"name"/archive/v"version".tar.gz"))
Please don’t use automatically generated tarballs, because they can
change over time. Github generates these tarballs on demand and caches
them for a long time, but they are not guaranteed to be permanent.
A regenerated tarball would have a different hash.
Please use git-fetch instead.
> + (synopsis "Standard dialog boxes for Windows, MacOS and Linux")
Please use “GTK+ dialog boxes for shell scripts”.
> + (description
> + "This program allows you to display GTK+ dialog boxes from command line
> or shell
> +scripts. More example of @code{yad} usage can be consulted at
> address@hidden://sourceforge.net/p/yad-dialog/wiki/browse_pages/}. The
> @code{yad}
> +depends on GTK+ only.")
I think we can drop the last sentence. How about this:
This program allows you to display GTK+ dialog boxes from the command
line or shell scripts. Example of how to use @code{yad} usage can be
found at @url{https://sourceforge.net/p/yad-dialog/wiki/browse_pages/}.
> + (license license:gpl3)))
The source files say that it’s gpl3+. Here’s an excerpt from the header
of yad/src/color.c:
* YAD is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 3 of the License, or
* (at your option) any later version.
Could you please send an updated patch?
--
Ricardo
- [bug#32584] [PATCH] gnu: Add yad.,
Ricardo Wurmus <=