[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#32565] [PATCHv3] Add python-falcon, python-falcon-cors.
From: |
Ludovic Courtès |
Subject: |
[bug#32565] [PATCHv3] Add python-falcon, python-falcon-cors. |
Date: |
Sun, 16 Sep 2018 22:31:55 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Hi Maxim,
Maxim Cournoyer <address@hidden> skribis:
>>From c3a1955a2198310b3c096e539eaaaf57a79aa970 Mon Sep 17 00:00:00 2001
> From: Maxim Cournoyer <address@hidden>
> Date: Wed, 29 Aug 2018 00:06:28 -0400
> Subject: [PATCH 1/2] gnu: Add python-falcon.
>
> * gnu/packages/python-web.scm (python-falcon): New variable.
[...]
> + (home-page "https://falconframework.org")
> + (synopsis
> + "Unladen web framework for building APIs and app backends")
> + (description
> + "Falcon is a bare-metal Python web API framework for building
> +high-performance microservices, app backends, and higher-level frameworks.")
If you could make it a bit less catchy and more concrete (giving example
of actual features), that would be great. :-)
>>From 3ecfbe57465aed1062c56ae2b42165a5a07605b5 Mon Sep 17 00:00:00 2001
> From: Maxim Cournoyer <address@hidden>
> Date: Wed, 29 Aug 2018 00:33:17 -0400
> Subject: [PATCH 2/2] gnu: Add python-falcon-cors.
>
> * gnu/packages/python-web.scm (python-falcon-cors): New variable.
[...]
> + (home-page
> + "https://github.com/lwcolton/falcon-cors")
> + (synopsis "Falcon CORS middlware")
^^
Typo.
What about “Falcon @dfn{cross-origin resource sharing} (CORS) library”?
> + (description "This middleware provides CORS support for Falcon.")
Ditto here, and bonus points if you add a couple of sentences to explain
what it does concretely. :-)
Last point: unless you need them, you can remove the “python2-” variants
since Python 2.x is reaching end-of-life.
OK to push with changes along these lines.
Thank you!
Ludo’.