[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#29856: [PATCH core-updates] guix: python-build-system:, Modify ".py"
From: |
Ricardo Wurmus |
Subject: |
bug#29856: [PATCH core-updates] guix: python-build-system:, Modify ".py" files in-place. |
Date: |
Mon, 04 Feb 2019 08:58:21 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Danny Milosavljevic <address@hidden> writes:
>
> On Tue, 2 Jan 2018 17:13:15 +0100
> Hartmut Goebel <address@hidden> wrote:
>
>> * it kills "from __future__ import", which must be the first import
>> statement (or even the first statement after any doc-string) to work.
>
> ... oops.
>
>> Thus I suggest aiming to implement the solution discussed in that thread
>> (see esp.
>> <https://lists.gnu.org/archive/html/guix-devel/2017-11/msg00041.html>.
>
> I like that approach. Nice...
>
>> Beside of this, the patch suffers from some more issues. Sorry to say :-(
>>
>> * When converting PYTHONPATH into a list of python strings, these need
>> to be quoted properly.
>
> I agree.
>
>> * The description (commit-message) of the patch is much to terse. It
>> should describe the the reason and implications. Esp. it should
>> describe the case this is fixing.
>
> Sure.
I’m closing this in favour of #29951.
Thanks!
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- bug#29856: [PATCH core-updates] guix: python-build-system:, Modify ".py" files in-place.,
Ricardo Wurmus <=