[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#34523] Add tetrinet
From: |
pkill9 |
Subject: |
[bug#34523] Add tetrinet |
Date: |
Tue, 19 Feb 2019 07:51:30 +0000 (GMT) |
I've attached an updated patch with the modifications suggested so far:
- Changed license from expat to public-domain
- Changed "No tests" to lowercase "no tests"
- Added "no configure file" comment
- Install Readme files
I indent the package definition in emacs by marking the package definition
(CTRL+Space) and running `M-x indent-region`, I'm not sure what indentation was
wrong with the original patch I submitted, but I ran indent-region on it again
anyway.
On Mon, 18 Feb 2019 15:11:37 +0100, Tobias Geerinckx-Rice <address@hidden>
wrote:
> pkill -9, Ricardo,
>
> Ricardo Wurmus wrote:
> > address@hidden writes:
> >> + `(#:tests? #f ; No tests.
>
> Only nitpicks:
>
> + `(#:tests? #f ; no tests
>
> If you're using emacs, running C-M-q on the whole definition will
> automatically indent your code. There's a way to do the same
> without emacs, but I forget how.
>
> >> + #:phases (modify-phases %standard-phases
> >> + (delete 'configure)
>
> + (delete 'configure) ; no configure script
>
> >> + (add-after 'unpack 'fix-install-dir
> >> + (lambda* (#:key outputs
> >> #:allow-other-keys)
> >> + (let ((out (assoc-ref outputs "out")))
> >> + (mkdir-p (string-append out "/bin"))
> >> + (substitute* "Makefile"
> >> + (("/usr/games") (string-append out
> >> "/bin")))))))))
> >
> > Can this patching be avoided by passing a make flag instead?
>
> Nope, it's hard-coded in the Makefile target :-(
>
> Considering the lack of a man(ual) page, how about adding
> something like:
>
> (add-after 'install 'install-documentation
> (lambda* (#:key outputs #:allow-other-keys)
> (let* ((out (assoc-ref outputs "out"))
> (doc (string-append out "/share/doc/"
> ,name "-" ,version)))
> (for-each (lambda (file)
> (install-file file doc))
> (list "README" "tetrinet.txt"))
> #t))))))
>
> Thanks!
>
> T G-R
0001-gnu-Add-tetrinet.patch
Description: Text Data
- [bug#34523] Add tetrinet, pkill9, 2019/02/18
- [bug#34523] Add tetrinet, Ricardo Wurmus, 2019/02/18
- [bug#34523] Add tetrinet, Tobias Geerinckx-Rice, 2019/02/18
- [bug#34523] Add tetrinet,
pkill9 <=
- [bug#34523] Add tetrinet, swedebugia, 2019/02/23
- [bug#34523] Add tetrinet, swedebugia, 2019/02/23
- [bug#34523] Add tetrinet, pkill9, 2019/02/26
- [bug#34523] Add tetrinet, swedebugia, 2019/02/26
- [bug#34523] Add tetrinet, pkill9, 2019/02/27
[bug#34523] Add tetrinet, pkill9, 2019/02/26
[bug#34523] Add tetrinet, pkill9, 2019/02/27