[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#34514] [PATCH 01/34] gnu: Add ruby-hamster.
From: |
Ricardo Wurmus |
Subject: |
[bug#34514] [PATCH 01/34] gnu: Add ruby-hamster. |
Date: |
Wed, 20 Feb 2019 08:48:11 +0100 |
User-agent: |
mu4e 1.0; emacs 26.1 |
Christopher Baines <address@hidden> writes:
> Ricardo Wurmus <address@hidden> writes:
>
>> Christopher Baines <address@hidden> writes:
>>
>>> * gnu/packages/ruby.scm (ruby-hamster): New variable.
>> […]
>>> + (add-after 'unpack 'remove-unnecessary-dependencies
>>> + (lambda _
>>> + ;; pry is a debugging tool, and is unnecessary when running the
>>> + ;; tests
>>> + (substitute* "spec/lib/hamster/vector/insert_spec.rb"
>>> + (("require 'pry'") ""))
>>> + (substitute* "spec/spec_helper.rb"
>>> + (("require \"pry\"") "")
>>
>> We have a ruby-pry package. Wouldn’t it be nicer to add it instead of
>> patching the sources?
>
> It would make the package definition simpler, but it would lead to
> redundant rebuilds of this package, and all of it's dependants if the
> ruby-pry package changed.
>
> The ideal situation would be for things like this to be optional, but I
> think where this isn't the case, it's worth putting some effort in to
> the package definition to avoid unnecessary dependencies.
Okay, sounds fine to me.
--
Ricardo
- [bug#34514] [PATCH 30/34] gnu: Add ruby-execjs., (continued)
- [bug#34514] [PATCH 30/34] gnu: Add ruby-execjs., Christopher Baines, 2019/02/17
- [bug#34514] [PATCH 32/34] gnu: Add ruby-rspec-rails., Christopher Baines, 2019/02/17
- [bug#34514] [PATCH 31/34] gnu: ruby: Update some RSpec packages., Christopher Baines, 2019/02/17
- [bug#34514] [PATCH 33/34] gnu: Add ruby-autoprefixer-rails., Christopher Baines, 2019/02/17
- [bug#34514] [PATCH 28/34] gnu: Add ruby-bindex., Christopher Baines, 2019/02/17
- [bug#34514] [PATCH 26/34] gnu: Remove ruby-listen-3.0., Christopher Baines, 2019/02/17
- [bug#34514] [PATCH 34/34] gnu: Add ruby-rerun., Christopher Baines, 2019/02/17
- [bug#34514] [PATCH 16/34] gnu: Add libsass., Christopher Baines, 2019/02/17
- [bug#34514] [PATCH 01/34] gnu: Add ruby-hamster., Ricardo Wurmus, 2019/02/18