[bug#34959] Acknowledgement ([PATCH] Add Multiple Common Lisp Packages)

[Ricardo Wurmus]

Hi Katherine,

> Of course as soon as I push it up and review it I find all the junk i
> left in. Here's a cleaner patch, with apologies.
>
> From d40bd8e4b7b2637b088ea3c14825fd4062625e22 Mon Sep 17 00:00:00 2001
> From: Katherine Cox-Buday <address@hidden>
> Date: Sat, 23 Mar 2019 15:01:11 -0500
> Subject: [PATCH] Add Multiple Common Lisp Packages

thank you for the patch!

We usually expect one commit per independent change.  Could you please
split up this patch into multiple commits?  You can group package
variants like “sbcl-trivial-backtrace” and “cl-trivial-backtrace”, but
separate packages generally each should have their own commit.


> +(define-public sbcl-trivial-backtrace
> +  (let ((commit-hash "ca81c011b86424a381a7563cea3b924f24e6fbeb"))
> +    (package
> +     (name "sbcl-trivial-backtrace")
> +     (synopsis "Portable simple API to work with backtraces in Common Lisp")
> +     (description "On of the many things that didn't quite get into the 
> Common Lisp standard was how to get a Lisp to output its call stack when 
> something has gone wrong. As such, each Lisp has developed its own notion of 
> what to display, how to display it, and what sort of arguments can be used to 
> customize it. trivial-backtrace is a simple solution to generating a 
> backtrace portably.")

Please break up long lines like this.  Please run “./pre-inst-env guix
lint sbcl-trivial-backtrace”, which will tell you about this problem.

> +     (home-page "https://common-lisp.net/project/trivial-backtrace/";)
> +     (license license:bsd-style)
> +     (version (string-append "0.0.0-" (string-take commit-hash 7)))

Please use “git-version” here.  Please also use a revision string, which
allows us to build version strings that can be sorted, e.g. when the
base version is unchanged and a newer commit is “smaller” than the
previous one.

> +     (source
> +      (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/gwkkwg/trivial-backtrace.git";)
> +             (commit commit-hash)))

Throughout you can use “commit” instead of “commit-hash” — there is no
naming conflict.

> +       (sha256 (base32 
> "10p41p43skj6cimdg8skjy7372s8v2xpkg8djjy0l8rm45i654k1"))))
> +     (inputs
> +      `(("sbcl-lift" ,sbcl-lift)))
> +     (build-system asdf-build-system/sbcl))))

Generally, I would like to suggest to keep the order of fields
consistent with the order used in other packages:

name, source, build-system, arguments, {native-,propagated-,}inputs,
home-page, synopsis, description, license.

--
Ricardo