[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#34807] [PATCH 1/2] Add (guix lzlib).
From: |
Pierre Neidhardt |
Subject: |
[bug#34807] [PATCH 1/2] Add (guix lzlib). |
Date: |
Sat, 04 May 2019 12:23:23 +0200 |
Right on time, I just finished it!
- I've been in touch with Antonio, Lzip's maintainer, for more than a
week and now I'm confident that I have a decent understanding of the
library.
- Your m4 suggestion didn't work. I've included a comment. We need to
fix it before merging. I'm not the right person for this job I'm
afraid :p Ludo?
- The convenience functions do not support multi-member archives.
Multi-member archives are mostly useful for parallelization, but we
don't use that in Guix, so it's OK. Should it be required some day,
we would need to implement it, which requires a little bit more work.
I've documented all that.
- The implementation of lzread! is subpar because I understood a
subtlety a bit too late. But that's alright, it does not affect
performance nor reliability.
- I've included 11 tests covering all your suggestions.
- I haven't strace'd the Guile process. The code regarding ports is
identical to zlib.scm, so it's unlikely there would be an issue in
this area. I have never done this before, so out of curiosity, how do
you run a specific Guix tests without going through `make'?
Next steps? :D
--
Pierre Neidhardt
https://ambrevar.xyz/
signature.asc
Description: PGP signature
0001-Add-guix-lzlib.patch
Description: Text Data
0002-dir-locals.el-Add-call-with-lzip-input-port-and-call.patch
Description: Text Data
- [bug#34807] [PATCH 1/2] Add (guix lzlib)., Pierre Neidhardt, 2019/05/01
- [bug#34807] [PATCH 1/2] Add (guix lzlib)., Pierre Neidhardt, 2019/05/02
- [bug#34807] [PATCH 1/2] Add (guix lzlib)., Ludovic Courtès, 2019/05/04
- [bug#34807] [PATCH 1/2] Add (guix lzlib).,
Pierre Neidhardt <=
- [bug#34807] [PATCH 1/2] Add (guix lzlib)., Ludovic Courtès, 2019/05/04
- [bug#34807] [PATCH 1/2] Add (guix lzlib)., Pierre Neidhardt, 2019/05/04
- [bug#34807] [PATCH 1/2] Add (guix lzlib)., Ludovic Courtès, 2019/05/06
- [bug#34807] [PATCH 1/2] Add (guix lzlib)., Tobias Geerinckx-Rice, 2019/05/06
- [bug#34807] [PATCH 1/2] Add (guix lzlib)., Pierre Neidhardt, 2019/05/07
- bug#34807: [PATCH 1/2] Add (guix lzlib)., Ludovic Courtès, 2019/05/07
- [bug#34807] [PATCH 1/2] Add (guix lzlib)., Pierre Neidhardt, 2019/05/07
- [bug#34807] [PATCH 1/2] Add (guix lzlib)., Ludovic Courtès, 2019/05/07