[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#36477] [PATCH 07/31] gnu: libgpg-error: Fix cross compilation.
From: |
Ludovic Courtès |
Subject: |
[bug#36477] [PATCH 07/31] gnu: libgpg-error: Fix cross compilation. |
Date: |
Mon, 15 Jul 2019 22:24:38 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
Hello,
Mathieu Othacehe <address@hidden> skribis:
> * gnu/packages/gnupg.scm (libgpg-error)[arguments]: Add a lock-obj header to
> the target platform when cross-compiling,
> [native-inputs]: add gettext that is needed when cross-compiling.
[...]
> + (arguments
> + (if (%current-target-system)
> + `(#:modules ((ice-9 match)
> + (guix build gnu-build-system)
> + (guix build utils))
> + #:phases
> + (modify-phases %standard-phases
> + (add-after 'unpack 'cross-symlinks
> + (lambda* (#:key inputs #:allow-other-keys)
> + (let* ((target ,(%current-target-system))
> + (tuple
> + (match (string-take target (string-index target
> #\-))
> + ("armhf" "arm-unknown-linux-gnueabi")
> + (x
> + (string-append x "-unknown-linux-gnu")))))
Two things:
1. s/tuple/triplet/
2. The target triplet is actually passed as a keyword argument to
phases. So if I’m not mistaken, you can write:
(lambda* (#:key target …)
…)
and get rid of the ‘match’ form above.
> + (symlink
> + (string-append "lock-obj-pub." tuple ".h")
> + "src/syscfg/lock-obj-pub.linux-gnu.h"))
If possible, a short comment or a link to some upstream discussion that
explains this would be helpful.
Could you send an updated patch?
Thank you,
Ludo’.
[bug#36477] [PATCH 07/31] gnu: libgpg-error: Fix cross compilation., Mathieu Othacehe, 2019/07/08
- [bug#36477] [PATCH 07/31] gnu: libgpg-error: Fix cross compilation.,
Ludovic Courtès <=
[bug#36477] [PATCH 04/31] gnu: tk: Fix cross-compilation., Mathieu Othacehe, 2019/07/08
[bug#36477] [PATCH 11/31] gnu: texinfo: Fix cross-compilation., Mathieu Othacehe, 2019/07/08
[bug#36477] [PATCH 08/31] gnu: python: Fix cross-compilation., Mathieu Othacehe, 2019/07/08
[bug#36477] [PATCH 16/31] gnu: groff: Fix cross compilation., Mathieu Othacehe, 2019/07/08
[bug#36477] [PATCH 23/31] gnu: help2man: Fix cross-compilation., Mathieu Othacehe, 2019/07/08
[bug#36477] [PATCH 19/31] gnu: indent: Fix aarch64 cross-compilation., Mathieu Othacehe, 2019/07/08