[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#36658] [PATCH] gnu: Add emacs-zerodark-theme.
From: |
Tino il Cotechino |
Subject: |
[bug#36658] [PATCH] gnu: Add emacs-zerodark-theme. |
Date: |
Fri, 19 Jul 2019 12:30:23 +0200 |
Hello,
I'm not sure why but I was convinced that guix import would run guix
lint on the generated package, so I didn't even try to run it. I'll pay
more attention next time.
The attached patch should fix all previous problems.
Thank you for your review!
Giacomo
On Wed, 2019-07-17 at 15:35 +0200, Ludovic Courtès wrote:
> Hello,
>
> Giacomo Leidi <address@hidden> skribis:
>
> > * gnu/packages/emacs-xyz.scm (emacs-zerodark-theme): New variable.
>
> Thanks for this patch! Below are a couple of suggestions.
>
> > +(define-public emacs-zerodark-theme
> > + (package
> > + (name "emacs-zerodark-theme")
>
> ^
> The indentation is off here (you can do M-q to fix it if you use
> paredit).
>
> > + (version "20190528.923")
> > + (source
> > + (origin
> > + (method url-fetch)
> > + (uri (string-append
> > + "https://melpa.org/packages/zerodark-theme-"
> > + version
> > + ".el"))
>
> This URL is unstable: the file will be modified in place regularly.
> Consequently, could you instead use the upstream Git repository URL
> along with the ‘git-fetch’ method?
>
> > + (synopsis
> > + "A dark, medium contrast theme for Emacs")
>
> ^
> Please remove “A”, as suggested by ‘guix lint’.
>
> > + (description
> > + "A dark theme inspired from One Dark and Niflheim.
>
> Please write a full sentence (info "(guix) Synopses and
> Descriptions").
>
> > +An optional mode-line format can be enabled with 'zerodark-setup-
> > modeline-format'.")
>
> ^
> Please use @code as suggested by ‘guix lint’.
>
> Could you send an updated patch?
>
> Thanks!
>
> Ludo’.
0001-gnu-Add-emacs-zerodark-theme.patch
Description: Text Data