[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#37138] [PATCH] gnu: Add speedcrunch.
From: |
Ludovic Courtès |
Subject: |
[bug#37138] [PATCH] gnu: Add speedcrunch. |
Date: |
Wed, 28 Aug 2019 18:33:29 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
Hello Steve,
Steve Sprang <address@hidden> skribis:
> From a3dfe6c0fa6f5fddc3c47e7501e37ba11902eb80 Mon Sep 17 00:00:00 2001
> From: Steve Sprang <address@hidden>
> Date: Wed, 21 Aug 2019 17:17:02 -0700
> Subject: [PATCH] gnu: Add speedcrunch.
>
> * gnu/packages/maths.scm (speedcrunch): New variable.
Nice. A couple of comments:
> + (source (origin
> + (method url-fetch)
> + (uri (string-append "https://bitbucket.org/heldercorreia/"
> + "speedcrunch/get/release-" version
> + ".tar.gz"))
I suspect this /get URL returns a generated tarball, whose exact content
might change over time. If that is the case, could you instead use
‘git-fetch’ (or ‘hg-fetch’)?
> + (inputs `(("qt" ,qt)))
Please use ‘qtbase’ & co., aka. the “modular Qt packages”. The ‘qt’
package is the old monolithic package and is actually deprecated.
Could you send an updated patch?
Thanks!
Ludo’.