[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#37813] [PATCH] gnu: mingw-w64: Add -winpthreads variants.
From: |
Ludovic Courtès |
Subject: |
[bug#37813] [PATCH] gnu: mingw-w64: Add -winpthreads variants. |
Date: |
Mon, 21 Oct 2019 22:53:50 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Hello!
Jan Nieuwenhuizen <address@hidden> skribis:
>> Thank you for your thorough review, definitely a lot to learn for me
>> still :-)
>
> You're welcome -- however my patches are no better than yours, I was
> very happy with its state.
Yes, the patch LGTM as well!
>>> As a general remark, in GNU we avoid the use the prefix `win' when we
>>> mean Microsoft Windows. We either use `windows' in full, or `w' (or
>>> w32). (https://www.gnu.org/prep/standards/html_node/Trademarks.html).
>>>
>>> So, what about using `-windows-pthreads' and `with-windows-pthreads',
>>> throughout?
>>
>> Actually, the library itself is called `winpthreads` according to
>> http://mingw-w64.org/ and as seen in the codebase here:
>> https://sourceforge.net/p/mingw-w64/mingw-w64/ci/master/tree/mingw-w64-libraries/winpthreads/,
>> is that okay?
>
> Ah, I see. That is unfortunate. We would need a maintainer to decide
> then, I'm CC'ing Ludo'. Personally I would still prefer
> `windows-pthreads' or `wpthreads'.
I’d lean towards keeping the upstream name, so “winpthreads”, as per the
current package naming policy (info "(guix) Package Naming").
Thanks,
Ludo’.